Page MenuHomeFreeBSD

bio aio: Destroy ephemeral mapping before unwiring page.
ClosedPublic

Authored by kib on Nov 28 2020, 10:40 PM.

Details

Summary

Apparently some architectures, like ppc in its hashed page tables variants, account mappings by pmap_qenter() in the response from pmap_is_page_mapped().

Reported by: alc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.Nov 28 2020, 10:40 PM
alc added inline comments.
sys/kern/vfs_aio.c
2348–2349 ↗(On Diff #80101)

These two assignments are only relevant if job->pbuf != NULL. So, they could move inside the "if" statement, just before the AIO_LOCK(ki). (In fact, I would just eliminate the variable userp.)

This revision is now accepted and ready to land.Nov 29 2020, 12:03 AM
kib marked an inline comment as done.
kib retitled this revision from Destroy emphemeral mapping before unwiring page. to bio aio: Destroy ephemeral mapping before unwiring page..

Eliminate userp.

This revision now requires review to proceed.Nov 29 2020, 9:15 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2020, 10:31 AM
This revision was automatically updated to reflect the committed changes.