Page MenuHomeFreeBSD

kern: dup: do not assume oldfde is valid
ClosedPublic

Authored by kevans on Nov 22 2020, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 2:22 AM
Unknown Object (File)
Thu, Oct 9, 11:37 PM
Unknown Object (File)
Thu, Sep 25, 1:50 AM
Unknown Object (File)
Fri, Sep 12, 10:14 PM
Unknown Object (File)
Sep 7 2025, 9:10 PM
Unknown Object (File)
Aug 15 2025, 4:14 PM
Unknown Object (File)
Aug 11 2025, 2:41 AM
Unknown Object (File)
Aug 8 2025, 4:58 AM
Subscribers

Details

Summary

oldfde may be invalidated if the table has grown due to the operation that we're performing, either via fdalloc() or a direct fdgrowtable_exp().

This was technically OK before rS367927 because the old table remained valid until the filedesc became unused, but now it may be freed immediately if it's an unshared table in a single-threaded process, so it is no longer a good assumption to make.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I can confirm this fixes the panic that I introduced in r367927.

This revision is now accepted and ready to land.Nov 22 2020, 10:38 PM
This revision was automatically updated to reflect the committed changes.