Differential D27265

Use the standard method for localizing of MSI-X table bar.
ClosedPublic
Actions

Authored by mmel on Nov 18 2020, 12:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 25, 1:24 AM

	Unknown Object (File)
	Mon, Feb 24, 7:15 AM

	Unknown Object (File)
	Sun, Feb 23, 11:40 PM

	Unknown Object (File)
	Sun, Feb 23, 11:20 PM

	Unknown Object (File)
	Sat, Feb 22, 2:33 PM

	Unknown Object (File)
	Fri, Feb 14, 11:34 PM

	Unknown Object (File)
	Wed, Feb 12, 9:15 PM

	Unknown Object (File)
	Wed, Feb 12, 6:02 PM

View All 60 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Intel Networking

Commits

rS368698: Use the standard method for localizing of MSI-X table bar.

Summary

Current way, hardcoded value plus heuristic is not conform to the PCI(e)
specification and fails on systems where MSI-X bar is not initialized by
BIOS/ACPI (many arm or arm64 systems for example).
Instead, use the standard PCI(e) capability for determining of
MSIX table bar address.

MFC after: 3 weeks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mmel created this revision.Nov 18 2020, 12:56 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 18 2020, 12:56 PM

mmel requested review of this revision.Nov 18 2020, 12:56 PM

erj edited reviewers, added: Intel Networking; removed: erj.Nov 24 2020, 9:31 PM

erj added a subscriber: Intel Networking.

erj removed a subscriber: Intel Networking.

ping.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2020, 2:39 PM

Closed by commit rS368698: Use the standard method for localizing of MSI-X table bar. (authored by mmel). · Explain Why

This revision was automatically updated to reflect the committed changes.

mmel added a commit: rS368698: Use the standard method for localizing of MSI-X table bar..

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

e1000/

1 line

6 lines

Diff 80762

head/sys/dev/e1000/if_em.h

Loading...

head/sys/dev/e1000/if_em.c

Loading...