Page MenuHomeFreeBSD

nfs: Mark unused statistics variable as reserved
ClosedPublic

Authored by asomers on Tue, Nov 17, 6:56 PM.

Details

Summary

nfs: Mark unused statistics variable as reserved

FreeBSD's NFS exporter has long exported some unused statistics fields.
Revision r366992 removed them from nfsstat. This revision renames those
fields in the kernel's exported structures to make it clear to other
consumers that they are unused.

Reported-by: emaste

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Thanks! I started looking at this, but noticed it was not completely trivial (i.e., because of sys/fs/nfs/nfs_commonport.c).

LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Nov 18, 4:36 AM
This revision was automatically updated to reflect the committed changes.

Looks fine. I didn't get around to reviewing it because
I was away from home and didn't take my laptop
charger with me--->dead battery...doh