Page MenuHomeFreeBSD
Differential D27258

nfs: Mark unused statistics variable as reserved
ClosedPublic
Actions

Authored by asomers on Nov 17 2020, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 7:15 AM
Unknown Object (File)
Oct 25 2024, 2:54 AM
Unknown Object (File)
Oct 20 2024, 12:45 PM
Unknown Object (File)
Oct 6 2024, 10:44 AM
Unknown Object (File)
Sep 24 2024, 8:42 PM
Unknown Object (File)
Sep 24 2024, 8:41 PM
Unknown Object (File)
Sep 24 2024, 8:41 PM
Unknown Object (File)
Sep 24 2024, 8:41 PM
View All 55 Files
Subscribers
imp

Details

Reviewers
rmacklem
emaste
Commits
rS367785: nfs: Mark unused statistics variable as reserved
Summary

nfs: Mark unused statistics variable as reserved

FreeBSD's NFS exporter has long exported some unused statistics fields.
Revision r366992 removed them from nfsstat. This revision renames those
fields in the kernel's exported structures to make it clear to other
consumers that they are unused.

Reported-by: emaste

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Nov 17 2020, 6:56 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 17 2020, 6:56 PM
asomers requested review of this revision.Nov 17 2020, 6:56 PM
Harbormaster completed remote builds in B34863: Diff 79674.Nov 17 2020, 6:56 PM
asomers updated this revision to Diff 79675.Nov 17 2020, 6:58 PM

Add missing files

Harbormaster completed remote builds in B34864: Diff 79675.Nov 17 2020, 6:58 PM
emaste added a comment.Nov 18 2020, 3:53 AM

Thanks! I started looking at this, but noticed it was not completely trivial (i.e., because of sys/fs/nfs/nfs_commonport.c).

LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2020, 4:36 AM
Closed by commit rS367785: nfs: Mark unused statistics variable as reserved (authored by asomers). · Explain Why
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS367785: nfs: Mark unused statistics variable as reserved.
rmacklem added a comment.Nov 19 2020, 12:43 AM

Looks fine. I didn't get around to reviewing it because
I was away from home and didn't take my laptop
charger with me--->dead battery...doh

Revision Contents
Changeset List

PathSize
head/
sys/
fs/
nfs/
19 lines
18 lines
nfsserver/
6 lines

Diff 79693

View Options

head/sys/fs/nfs/nfs_commonport.c

Loading...
View Options

head/sys/fs/nfs/nfsport.h

Loading...
View Options

head/sys/nfsserver/nfsrvstats.h

Loading...