malloc: make malloc_large closer to standalone
ClosedPublic
Actions

Authored by mjg on Nov 12 2020, 9:11 PM.

Details

Reviewers

markj

Commits

rS367733: malloc: make malloc_large closer to standalone

Summary

This moves entire large alloc handling out of all consumers, apart from deciding to go there.

Apart from shortening malloc as it is it makes it feasible to replace the allocation code with smaller helpers to create a fast path.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 34768

Event Timeline

mjg created this revision.Nov 12 2020, 9:11 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 12 2020, 9:11 PM

mjg requested review of this revision.Nov 12 2020, 9:12 PM

Harbormaster completed remote builds in B34768: Diff 79483.Nov 12 2020, 9:12 PM

markj accepted this revision.Nov 13 2020, 3:47 PM

markj added inline comments.

sys/kern/kern_malloc.c
590	Below it is `ifdef DEBUG_REDZONE`, would be nice to make it consistent.

This revision is now accepted and ready to land.Nov 13 2020, 3:47 PM

fix a redzone bug. malloc_dbg can bump the size over kmem_zmax, meaning it has to happen before checking for malloc_large

This revision now requires review to proceed.Nov 16 2020, 12:34 AM

markj accepted this revision.Nov 16 2020, 5:01 PM

This revision is now accepted and ready to land.Nov 16 2020, 5:01 PM

Closed by commit rS367733: malloc: make malloc_large closer to standalone (authored by mjg). · Explain WhyNov 16 2020, 5:57 PM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rS367733: malloc: make malloc_large closer to standalone.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_malloc.c

128 lines

Diff 79483

View Options

malloc: make malloc_large closer to standaloneClosedPublicActions