Page MenuHomeFreeBSD

Match all MIPS and RISC-V MACHINE_ARCH values
AbandonedPublic

Authored by brooks on Nov 10 2020, 12:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 3 2024, 9:43 PM
Unknown Object (File)
Dec 29 2023, 9:54 PM
Unknown Object (File)
Dec 23 2023, 3:20 PM
Unknown Object (File)
Dec 20 2023, 8:01 AM
Unknown Object (File)
Nov 25 2023, 3:52 PM
Unknown Object (File)
Oct 22 2023, 9:25 AM
Unknown Object (File)
Sep 15 2023, 7:40 PM
Unknown Object (File)
Aug 11 2023, 9:06 AM
Subscribers

Details

Reviewers
se
jrtc27
Summary

The simple equality checks missed most possible values of MACHINE_ARCH
for MIPS and RISC-V. Compare to MACHINE_CPUARCH instead.

Use a glob for powerpc64 owing to powerpc64le.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34895
Build 31916: arc lint + arc unit

Event Timeline

brooks created this revision.

There might be something to be said for a LINKER_FEATURES=lto in bsd.compiler.mk, but I'm not sure that we need to generalize from one example.

  • give powerpc64 the match treatment as well

I remember that powerpc64le is on it's way so I've given powerp64 the same treatment.

jrtc27 requested changes to this revision.Nov 18 2020, 1:22 PM
jrtc27 added a subscriber: jrtc27.
jrtc27 added inline comments.
usr.bin/gh-bc/Makefile
57–59
57–59

Though probably better as this. Also, is 32-bit powerpc definitely ok, or just not tested these days? Seems surprising that powerpc64 would be affected but not powerpc...

This revision now requires changes to proceed.Nov 18 2020, 1:22 PM
  • Fix powerpc64 case.
  • Use MACHINE_CPUARCH for mips and riscv

I'm likewise skeptical that any powerpc works

brooks edited the summary of this revision. (Show Details)

OOI do we know what the actual problem is? The comment is frustratingly light on detail so without trying it myself it's hard to have any idea where one would even look for a bug.

(and also extrapolate to other architectures)