Page MenuHomeFreeBSD

malloc: retire mt_stats_zone in favor of pcpu_zone_64
ClosedPublic

Authored by mjg on Nov 9 2020, 12:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 12:56 AM
Unknown Object (File)
Fri, Jan 10, 4:50 AM
Unknown Object (File)
Dec 15 2024, 6:12 AM
Unknown Object (File)
Nov 21 2024, 3:06 PM
Unknown Object (File)
Nov 4 2024, 10:57 AM
Unknown Object (File)
Nov 4 2024, 10:57 AM
Unknown Object (File)
Nov 4 2024, 10:57 AM
Unknown Object (File)
Nov 4 2024, 10:40 AM
Subscribers

Details

Summary

The former was only created because the latter did not exist at the time.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 34700

Event Timeline

mjg requested review of this revision.Nov 9 2020, 12:35 AM
This revision is now accepted and ready to land.Nov 9 2020, 12:57 AM

Did you consider adding a malloc_pcpu() instead of hard-coding the zone item size?

Yes, along with malloc_type equivalent. Using it here would be a little circular.

malloc_pcpu will possibly be written by me after malloc itself gets cleaned up. for example the zone selection method avoidably encodes size + pointer to a string in the same struct, making it less cache-friendly. once this is sorted out the same (cleaned up) method can be used for malloc_pcpu.

So eventually mti_stats would be allocated using malloc_pcpu()? Ok. BTW, V_pfr_kentry_counter_z consumers would benefit from such a function as well. Right now it's a per-VNET zone but I think there's no good reason for that.

This revision was automatically updated to reflect the committed changes.