Page MenuHomeFreeBSD
Differential D27076

amd64: Make it easier to configure exception stack sizes
ClosedPublic
Actions

Authored by markj on Nov 3 2020, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 11, 6:16 PM
Unknown Object (File)
Mon, May 11, 10:18 AM
Unknown Object (File)
Sun, May 10, 11:51 PM
Unknown Object (File)
Sun, May 10, 8:41 AM
Unknown Object (File)
Sat, May 2, 10:54 AM
Unknown Object (File)
Wed, Apr 29, 1:33 PM
Unknown Object (File)
Wed, Apr 29, 1:26 PM
Unknown Object (File)
Wed, Apr 29, 10:24 AM
View All Files
Subscribers
imp
NetApp

Details

Reviewers
kib
Commits
rS367335: amd64: Make it easier to configure exception stack sizes
Summary

We handle certain types of exceptions on a dedicated per-CPU stack.
Currently the sizes of these stacks are all hard-coded to PAGE_SIZE, but
for at least NMI handling it can be useful to configure larger stacks.
Add constants to intr_machdep.h to make this easier to tweak, since
exception stacks are allocated both in .bss and during AP startup.

No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Nov 3 2020, 3:09 PM
markj created this revision.
Harbormaster completed remote builds in B34599: Diff 79131.Nov 3 2020, 3:09 PM
markj added a reviewer: kib.Nov 3 2020, 3:09 PM
markj added a subscriber: NetApp.
kib added a comment.Nov 3 2020, 3:44 PM

You need to adjust pmap_pti_init() as well.

markj updated this revision to Diff 79133.Nov 3 2020, 4:29 PM

Make sure PTI uses the correct stack sizes.

Harbormaster completed remote builds in B34601: Diff 79133.Nov 3 2020, 4:29 PM
kib accepted this revision.Nov 3 2020, 5:35 PM
This revision is now accepted and ready to land.Nov 3 2020, 5:35 PM
Closed by commit rS367335: amd64: Make it easier to configure exception stack sizes (authored by markj). · Explain WhyNov 4 2020, 4:42 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS367335: amd64: Make it easier to configure exception stack sizes.
Herald added a subscriber: imp. · View Herald TranscriptNov 4 2020, 4:42 PM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
8 lines
19 lines
9 lines
include/
5 lines

Diff 79179

View Options

head/sys/amd64/amd64/machdep.c

Loading...
View Options

head/sys/amd64/amd64/mp_machdep.c

Loading...
View Options

head/sys/amd64/amd64/pmap.c

Loading...
View Options

head/sys/amd64/include/intr_machdep.h

Loading...