This removes a branch for handling an almost-unused case.
Slight clean up is in preparation for resurecting the fast path malloc/free patch.
Differential D27019
malloc: delegate M_EXEC handling to malloc_exec + clean up a little mjg on Oct 30 2020, 3:19 PM. Authored by Tags None Referenced Files
Subscribers
Details
This removes a branch for handling an almost-unused case. Slight clean up is in preparation for resurecting the fast path malloc/free patch.
Diff Detail
Event TimelineComment Actions I think this is fine. I wouldn't even bother with malloc_exec(), you could just modify the few existing users to call kmem_malloc(M_EXEC). In either case, a man page update is needed.
Comment Actions They had kmem_malloc and that got patched to malloc(...., M_EXEC) so I did not deviate from the general direction. That said, I'm indifferent to this one as long as the flag is gone from malloc itself. Comment Actions It was malloc(), then r317072 changed to kmem_malloc(), then it was changed back when M_EXEC was added. I don't have strong feelings either way; the main advantage of malloc_exec() is malloc type tracking. If you prefer having malloc_exec() then this diff LGTM so long as the man page is updated.
|