science/libctl: Update to 4.5.0
ClosedPublic
Actions

Authored by rhurlin on Oct 28 2020, 8:46 PM.

Details

Reviewers

arrowd
tcberner

Commits

rP553774: science/libctl: Update to 4.5.0

Summary

Update science/libctl from 3.2.2 to 4.5.0. Over several minor and a major version release there have been important bugfixes and enhancements [1].

[1] https://github.com/NanoComp/libctl/blob/master/NEWS.md

What this patch should do:

Update from 3.2.2 to 4.5.0
Change MASTER_SITES to the Github releases URL
Add LIB_DEPENDS=devel/boehm-gc-threaded and libguile-2.2.so:lang/guile2
'Bump' library version
Set option NLOPT default (needed by science/mpb)
Reorder some Makefile entries
Update URL in pkg-descr
Update pkg-plist

science/mpb depends on the update of this port. After the commit, I will put an update of science/mpb on Phabricator immediately.

science/libctl submitted in PR 249007, maintainer timeout since end of September.

Tested on Poudriere (amd64, i386), 'portlint -AC' seems happy.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rhurlin created this revision.Oct 28 2020, 8:46 PM

Herald added a subscriber: mat. · View Herald TranscriptOct 28 2020, 8:46 PM

rhurlin requested review of this revision.Oct 28 2020, 8:46 PM

Harbormaster completed remote builds in B34450: Diff 78867.Oct 28 2020, 8:46 PM

Looks good modulo indentation issue.

Does committing this leave science/mpb in a broken state? If yes, I'd prefer you to prepare two reviews (this one and mpb) and once both of them are approved commit them in one go.

science/libctl/Makefile
26 ↗	(On Diff #78867)	Indentation seems to not match with previous line.

This revision is now accepted and ready to land.Oct 30 2020, 6:49 AM

Fix unpleasant indentation for OPTIONS_DEFINE.

This revision now requires review to proceed.Oct 30 2020, 7:49 AM

Harbormaster completed remote builds in B34494: Diff 78942.Oct 30 2020, 7:49 AM

Forgot to put the updated pkg-plist in the review, sorry!

Harbormaster completed remote builds in B34495: Diff 78946.Oct 30 2020, 9:57 AM

In D26992#602651, @arrowd wrote:

Looks good modulo indentation issue.

Does committing this leave science/mpb in a broken state? If yes, I'd prefer you to prepare two reviews (this one and mpb) and once both of them are approved commit them in one go.

I agree, please include the update/fix of science/mpb in this review and commit them together

rhurlin mentioned this in D27031: science/mpb: Update to 1.11.1.Oct 31 2020, 9:50 AM

arrowd accepted this revision.Oct 31 2020, 10:02 AM

This revision is now accepted and ready to land.Oct 31 2020, 10:02 AM

Closed by commit rP553774: science/libctl: Update to 4.5.0 (authored by rhurlin). · Explain WhyOct 31 2020, 3:59 PM

This revision was automatically updated to reflect the committed changes.

rhurlin added a commit: rP553774: science/libctl: Update to 4.5.0.