Page MenuHomeFreeBSD

vmimage.subr: noisier failure for unsupported targets
ClosedPublic

Authored by mhorne on Oct 28 2020, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 7:17 PM
Unknown Object (File)
Sun, Sep 6, 3:29 PM
Unknown Object (File)
Sun, Sep 6, 9:03 AM
Unknown Object (File)
Sat, Sep 5, 11:25 PM
Unknown Object (File)
Thu, Sep 3, 1:08 PM
Unknown Object (File)
Thu, Sep 3, 10:45 AM
Unknown Object (File)
Wed, Sep 2, 6:21 PM
Unknown Object (File)
Wed, Sep 2, 1:37 PM
Subscribers

Details

Summary

The return code of write_partition_layout() doesn't bubble up, so an
invocation of make vm-release for an incorrect/unsupported target will
appear to succeed while make vm-install will fail due to missing
files. This isn't a common point of failure, but is worth handling
properly.

Upgrade this case to print a message to stderr, and exit in place. This
is okay to do since at this point in the execution of mk-vmimage.sh,
cleanup() has already been run.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable