Page MenuHomeFreeBSD

vmimage.subr: noisier failure for unsupported targets
ClosedPublic

Authored by mhorne on Oct 28 2020, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 7, 4:20 AM
Unknown Object (File)
Mon, Nov 3, 5:34 PM
Unknown Object (File)
Thu, Oct 30, 12:09 PM
Unknown Object (File)
Thu, Oct 30, 4:58 AM
Unknown Object (File)
Thu, Oct 30, 2:06 AM
Unknown Object (File)
Mon, Oct 27, 11:05 PM
Unknown Object (File)
Mon, Oct 27, 8:40 PM
Unknown Object (File)
Oct 26 2025, 3:40 AM
Subscribers

Details

Summary

The return code of write_partition_layout() doesn't bubble up, so an
invocation of make vm-release for an incorrect/unsupported target will
appear to succeed while make vm-install will fail due to missing
files. This isn't a common point of failure, but is worth handling
properly.

Upgrade this case to print a message to stderr, and exit in place. This
is okay to do since at this point in the execution of mk-vmimage.sh,
cleanup() has already been run.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable