Page MenuHomeFreeBSD

vmimage.subr: noisier failure for unsupported targets
ClosedPublic

Authored by mhorne on Oct 28 2020, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 12:46 AM
Unknown Object (File)
Tue, Aug 11, 6:33 AM
Unknown Object (File)
Sun, Aug 9, 1:19 AM
Unknown Object (File)
Sat, Aug 8, 10:10 PM
Unknown Object (File)
Sat, Aug 8, 7:35 PM
Unknown Object (File)
Sat, Aug 8, 1:21 PM
Unknown Object (File)
Fri, Aug 7, 12:50 PM
Unknown Object (File)
Fri, Aug 7, 6:25 AM
Subscribers

Details

Summary

The return code of write_partition_layout() doesn't bubble up, so an
invocation of make vm-release for an incorrect/unsupported target will
appear to succeed while make vm-install will fail due to missing
files. This isn't a common point of failure, but is worth handling
properly.

Upgrade this case to print a message to stderr, and exit in place. This
is okay to do since at this point in the execution of mk-vmimage.sh,
cleanup() has already been run.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable