Page MenuHomeFreeBSD

vmimage.subr: noisier failure for unsupported targets
ClosedPublic

Authored by mhorne on Oct 28 2020, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 1:11 AM
Unknown Object (File)
Sep 8 2025, 1:14 PM
Unknown Object (File)
Sep 2 2025, 10:41 PM
Unknown Object (File)
Sep 1 2025, 7:49 PM
Unknown Object (File)
Aug 28 2025, 12:31 AM
Unknown Object (File)
Aug 15 2025, 10:23 AM
Unknown Object (File)
Aug 11 2025, 5:01 PM
Unknown Object (File)
Aug 5 2025, 12:26 PM
Subscribers

Details

Summary

The return code of write_partition_layout() doesn't bubble up, so an
invocation of make vm-release for an incorrect/unsupported target will
appear to succeed while make vm-install will fail due to missing
files. This isn't a common point of failure, but is worth handling
properly.

Upgrade this case to print a message to stderr, and exit in place. This
is okay to do since at this point in the execution of mk-vmimage.sh,
cleanup() has already been run.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable