Page MenuHomeFreeBSD

vmimage.subr: noisier failure for unsupported targets
ClosedPublic

Authored by mhorne on Oct 28 2020, 2:08 PM.
Tags
None
Referenced Files
F140576172: D26985.id78970.diff
Thu, Dec 25, 11:50 AM
Unknown Object (File)
Tue, Dec 2, 5:24 AM
Unknown Object (File)
Thu, Nov 27, 10:06 AM
Unknown Object (File)
Nov 7 2025, 4:20 AM
Unknown Object (File)
Nov 3 2025, 5:34 PM
Unknown Object (File)
Oct 30 2025, 12:09 PM
Unknown Object (File)
Oct 30 2025, 4:58 AM
Unknown Object (File)
Oct 30 2025, 2:06 AM
Subscribers

Details

Summary

The return code of write_partition_layout() doesn't bubble up, so an
invocation of make vm-release for an incorrect/unsupported target will
appear to succeed while make vm-install will fail due to missing
files. This isn't a common point of failure, but is worth handling
properly.

Upgrade this case to print a message to stderr, and exit in place. This
is okay to do since at this point in the execution of mk-vmimage.sh,
cleanup() has already been run.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable