Page MenuHomeFreeBSD
Differential D26952

riscv: remove sbi_clear_ipi()
ClosedPublic
Actions

Authored by mhorne on Oct 25 2020, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 28, 11:39 PM
Unknown Object (File)
Mon, Sep 28, 11:34 PM
Unknown Object (File)
Mon, Sep 28, 11:02 PM
Unknown Object (File)
Sat, Sep 26, 8:34 AM
Unknown Object (File)
Fri, Sep 11, 10:32 AM
Unknown Object (File)
Sep 6 2026, 4:05 AM
Unknown Object (File)
Sep 6 2026, 3:25 AM
Unknown Object (File)
Sep 6 2026, 2:23 AM
View All Files
Subscribers
imp

Details

Reviewers
kp
jrtc27
Commits
rS367067: riscv: remove sbi_clear_ipi()
Summary

S-mode software has write access to the SIP.SSIP bit, so instead of
making a second round-trip through the SBI we can clear it ourselves.
The SBI spec has deprecated this function for this exactly this reason.

Submitted by: Danjel Q. <dan1222@gmail.com>

Test Plan

Boot to multiuser in QEMU.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Oct 25 2020, 10:24 PM
mhorne created this revision.
Harbormaster completed remote builds in B34391: Diff 78754.Oct 25 2020, 10:25 PM
kp accepted this revision.Oct 25 2020, 10:31 PM
This revision is now accepted and ready to land.Oct 25 2020, 10:31 PM
jrtc27 added inline comments.Oct 25 2020, 10:38 PM
sys/riscv/riscv/sbi.c
180 ↗(On Diff #78754)

It strikes me that we should probably panic if these fail even for -NODEBUG kernels?

mhorne added inline comments.Oct 25 2020, 10:42 PM
sys/riscv/riscv/sbi.c
180 ↗(On Diff #78754)

Yes we should. I'll see about a patch for that.

Closed by commit rS367067: riscv: remove sbi_clear_ipi() (authored by mhorne). · Explain WhyOct 26 2020, 7:06 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rS367067: riscv: remove sbi_clear_ipi().
Herald added a subscriber: imp. · View Herald TranscriptOct 26 2020, 7:06 PM

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
include/
7 lines
riscv/
2 lines
2 lines

Diff 78788

View Options

head/sys/riscv/include/sbi.h

Loading...
View Options

head/sys/riscv/riscv/mp_machdep.c

Loading...
View Options

head/sys/riscv/riscv/sbi.c

Loading...