Differential D26920

nfsstat: delete unused fields
ClosedPublic
Actions

Authored by asomers on Oct 23 2020, 7:20 PM.

Details

Reviewers

rmacklem

Commits

rS366992: nfsstat: delete unused fields

Summary

nfsstat: delete unused fields

Ever since r192762 nfsstat has included a few fields whose values were
always 0. They were copied from OpenBSD, but have never been used on
FreeBSD. Don't display them.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Oct 23 2020, 7:20 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2020, 7:20 PM

asomers requested review of this revision.Oct 23 2020, 7:20 PM

Harbormaster completed remote builds in B34340: Diff 78655.Oct 23 2020, 7:20 PM

nfsstat.diff6 KBDownload

Here's an example of the change in the command's output, for various command line options.

Seems ok to me.
There have already been commits that changed this
output format and no one has reported problems
because of that.
As such, I don't think this format change will
cause people problems.

This revision is now accepted and ready to land.Oct 23 2020, 11:38 PM

Closed by commit rS366992: nfsstat: delete unused fields (authored by asomers). · Explain WhyOct 24 2020, 5:52 AM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS366992: nfsstat: delete unused fields.