Page MenuHomeFreeBSD

net/socat: Fix OpenSSL build issues
ClosedPublic

Authored by brnrd on May 31 2015, 1:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 1:13 PM
Unknown Object (File)
Sun, Apr 21, 7:08 PM
Unknown Object (File)
Mar 6 2024, 9:29 AM
Unknown Object (File)
Feb 15 2024, 4:44 AM
Unknown Object (File)
Feb 2 2024, 9:13 AM
Unknown Object (File)
Jan 27 2024, 12:27 PM
Unknown Object (File)
Jan 21 2024, 11:43 AM
Unknown Object (File)
Jan 17 2024, 8:00 AM
Subscribers
None

Details

Summary

Proposed commit-log

net/socat: Fix OpenSSL build issues

 - While here fix CPE Vendor (NVD has dest-unreach)
 - Fix build when OpenSSL from ports was built without SSLv3 support
 - Fix build when OpenSSL is built without compression support
 - Fix build for OpenSSL 1.1.0pre without EGD support

PR:		197192
Reviewed_by:	koobs, feld, ehaupt
Approved by:	(mentor), ehaupt (maintainer)
Differential_Revision:	D2691

Upstream accepted the patch, will be part of a next release

Test Plan
  • testport (poudriere OK)
  • portlint (OK)
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 2 warnings found.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brnrd retitled this revision from to net/socat: Fix build when openssl is built without compression support.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: ehaupt, koobs, vsevolod.
brnrd updated this object.

Original xioopts.c patch was missing, don't modify timestamp

brnrd edited the test plan for this revision. (Show Details)
koobs requested changes to this revision.Jun 22 2015, 12:07 PM
koobs edited edge metadata.

I can't see any changes in this review? They all look empty, or displayed with no changes

Also:

  • Depends on: D2770 does not go in commit log
  • Differential revision: D2691 needs to be a full URL (and capital (R)evision iirc from the commit template)
  • Tab align all commit metadata lines
This revision now requires changes to proceed.Jun 22 2015, 12:07 PM
brnrd edited edge metadata.
brnrd edited edge metadata.

Re-roll patches for 1.7.3.1

koobs requested changes to this revision.Feb 2 2016, 12:23 PM
koobs edited edge metadata.
koobs added inline comments.
net/socat/files/patch-sslcls.c
1 ↗(On Diff #12951)

Add breadcrumbs with upstream issue/list/pr reference where applicable

net/socat/files/patch-sslcls.h
1 ↗(On Diff #12951)

Add breadcrumbs with upstream issue/list/pr reference where applicable

net/socat/files/patch-xio-openssl.c
1 ↗(On Diff #12951)

Add breadcrumbs with upstream issue/list/pr reference where applicable

net/socat/files/patch-xioopts.c
1 ↗(On Diff #12951)

Add breadcrumbs with upstream issue/list/pr reference where applicable

This revision now requires changes to proceed.Feb 2 2016, 12:23 PM
brnrd edited edge metadata.

Maintainer approval:

Hi Bernard

You're putting a lot of great effort into socat. I would like to give
you a implicit approval to commit to net/socat.

Feel free to commit to the port without asking. Just add to your commit.

Approved by: maintainer (implicit)

Emanuel

Upstream feedback (via email):

Hello,

1.7.3.1 was a pure security fix release.
If no new security issue overtakes, your patch will be in 1.7.3.2 (only
fixes and porting) or 1.7.4.0 (with new features).

I have no schedule yet, sorry.

Regards
Gerhard

There's no public source code repository or bug tacker to submit the patches.

No upstream issue/list/pr is available, only the email response.

brnrd edited reviewers, added: feld; removed: vsevolod.
brnrd retitled this revision from net/socat: Fix build when openssl is built without compression support to net/socat: Fix OpenSSL build issues.Feb 27 2016, 5:20 PM
brnrd updated this object.
brnrd updated this object.
brnrd edited edge metadata.

USES in alphabetical order

ehaupt edited edge metadata.

Looks good, please commit.

feld edited edge metadata.
This revision was automatically updated to reflect the committed changes.