Differential D26855

Fix fallout from r366811
ClosedPublic
Actions

Authored by trasz on Oct 19 2020, 11:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 28, 12:43 PM

	Unknown Object (File)
	Tue, Apr 8, 5:47 PM

	Unknown Object (File)
	Mar 22 2025, 10:40 AM

	Unknown Object (File)
	Mar 20 2025, 4:43 AM

	Unknown Object (File)
	Mar 16 2025, 2:47 PM

	Unknown Object (File)
	Feb 22 2025, 2:30 PM

	Unknown Object (File)
	Feb 22 2025, 2:08 PM

	Unknown Object (File)
	Feb 22 2025, 1:48 PM

View All 38 Files

Subscribers

Details

Reviewers

imp
mav

Commits

rS366855: Fix fallout from r366811.

Summary

Fix fallout from r366811.

PR: 250442

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Oct 19 2020, 11:24 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 19 2020, 11:24 AM

trasz requested review of this revision.Oct 19 2020, 11:24 AM

Harbormaster completed remote builds in B34255: Diff 78420.Oct 19 2020, 11:24 AM

trasz added reviewers: imp, mav.Oct 19 2020, 11:24 AM

mav added inline comments.Oct 19 2020, 1:52 PM

sys/geom/geom_dev.c
246 ↗	(On Diff #78420)	How can provider be NULL there, if this function either called by the provider or by g_dev_taste() where you are checking for attach error?
360 ↗	(On Diff #78420)	This part is OK, I am just thinking whether we should print this error, since as I see you are not doing it for other classes.

Drop unnecessary chunk and add another one, fixing error handling
in g_uzip(4).

Harbormaster completed remote builds in B34259: Diff 78432.Oct 19 2020, 3:25 PM

mav accepted this revision.Oct 19 2020, 3:30 PM

This revision is now accepted and ready to land.Oct 19 2020, 3:30 PM

emaste added a subscriber: emaste.Oct 19 2020, 4:40 PM

trasz added a subscriber: NetApp.Oct 19 2020, 5:26 PM

Closed by commit rS366855: Fix fallout from r366811. (authored by trasz). · Explain WhyOct 19 2020, 8:26 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS366855: Fix fallout from r366811..

trasz added inline comments.Oct 19 2020, 8:28 PM

sys/geom/geom_dev.c
360 ↗	(On Diff #78420)	I'd prefer to leave it for now, in case this triggers in some unexpected cases.

Revision Contents
Changeset List

Path

Size

head/

sys/

geom/

12 lines

uzip/

9 lines

Diff 78466

head/sys/geom/geom_dev.c

Loading...

head/sys/geom/uzip/g_uzip.c

Loading...