kern_sysctl: Misc code cleanup
ClosedPublic
Actions

Authored by freqlabs on Oct 19 2020, 6:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 25, 5:37 AM

	Unknown Object (File)
	Fri, Oct 25, 5:37 AM

	Unknown Object (File)
	Fri, Oct 25, 5:37 AM

	Unknown Object (File)
	Fri, Oct 25, 5:37 AM

	Unknown Object (File)
	Fri, Oct 25, 5:24 AM

	Unknown Object (File)
	Oct 3 2024, 3:52 PM

	Unknown Object (File)
	Sep 27 2024, 3:44 AM

	Unknown Object (File)
	Sep 13 2024, 8:41 PM

View All 70 Files

Subscribers

imp

Contributor Reviews (src)

Details

Reviewers

mjg
imp

Commits

rS367003: kern_sysctl: Misc code cleanup

Summary

Remove unused oidpp parameter from sysctl_sysctl_next_ls and add high level comments to describe how it works.

No functional change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

freqlabs created this revision.Oct 19 2020, 6:59 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptOct 19 2020, 6:59 AM

freqlabs requested review of this revision.Oct 19 2020, 6:59 AM

freqlabs added a child revision: D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.Oct 19 2020, 7:06 AM

freqlabs added a reviewer: mjg.Oct 23 2020, 2:58 PM

Dropped various whitespace fixes to preserve blame.

love it. And thanks for the different commits... I 100% agree with phab being a pita to setup review chains.

This revision is now accepted and ready to land.Oct 24 2020, 12:24 AM

Closed by commit rS367003: kern_sysctl: Misc code cleanup (authored by freqlabs). · Explain WhyOct 24 2020, 2:47 PM

This revision was automatically updated to reflect the committed changes.

freqlabs added a commit: rS367003: kern_sysctl: Misc code cleanup.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sysctl.c

63 lines

Diff 78642

View Options

kern_sysctl: Misc code cleanupClosedPublicActions