free.
ClosedPublic
Actions

Authored by trasz on Oct 18 2020, 6:15 PM.

Details

Reviewers

sbruno
imp
mav

Commits

rS367950: Make hptmv(4) use xpt_alloc_ccb/xpt_free_ccb instead of malloc/free.

Summary

Make hptmv(4) use xpt_alloc_ccb/xpt_free_ccb instead of malloc/free.
Unfortunately I don't have the hardware necessary to test it; testers
welcome.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Oct 18 2020, 6:15 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 18 2020, 6:15 PM

trasz requested review of this revision.Oct 18 2020, 6:15 PM

Harbormaster completed remote builds in B34243: Diff 78389.Oct 18 2020, 6:15 PM

trasz added reviewers: sbruno, imp, mav.Oct 18 2020, 6:16 PM

The core around this looks pretty weird to me, considering hpt_async() immediately calls panic(). But I don't expect troubles from this change.

This revision is now accepted and ready to land.Oct 18 2020, 7:08 PM

mav added inline comments.Oct 18 2020, 7:34 PM

sys/dev/hptmv/entry.c
2011 ↗	(On Diff #78389)	Since it is not _nowait it is not supposed to fail.

Agree with mav on both points. This looks low risk and correct

Closed by commit rS367950: Make hptmv(4) use xpt_alloc_ccb/xpt_free_ccb instead of malloc/free. (authored by trasz). · Explain WhyNov 23 2020, 12:58 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS367950: Make hptmv(4) use xpt_alloc_ccb/xpt_free_ccb instead of malloc/free..

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hptmv/

entry.c

5 lines

Diff 79884

View Options

head/sys/dev/hptmv/entry.c

hptmv(4): use xpt_alloc_ccb/xpt_free_ccb instead of malloc/free.ClosedPublicActions