arcmsr(4): don't bzero newly allocated ccb
ClosedPublic
Actions

Authored by trasz on Oct 18 2020, 5:38 PM.

Details

Reviewers

delphij
imp

Commits

rS367948: arcmsr(4): don't bzero newly allocated ccb; xpt_alloc_ccb() already does that.

Summary

arcmsr(4): don't bzero newly allocated ccb; xpt_alloc_ccb() already does that.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Oct 18 2020, 5:38 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 18 2020, 5:38 PM

Harbormaster completed remote builds in B34241: Diff 78387.Oct 18 2020, 5:38 PM

trasz requested review of this revision.Oct 18 2020, 5:38 PM

trasz added a reviewer: delphij.Oct 18 2020, 5:40 PM

trasz added a subscriber: NetApp.

imp accepted this revision.Oct 18 2020, 5:54 PM

imp added inline comments.

sys/dev/arcmsr/arcmsr.c
1673 ↗	(On Diff #78387)	This cast likely isn't needed either.

This revision is now accepted and ready to land.Oct 18 2020, 5:54 PM

LGTM, could you please also send the patch to the maintainer ( ching2048@areca.com.tw )?

In D26840#598447, @delphij wrote:

LGTM, could you please also send the patch to the maintainer ( ching2048@areca.com.tw )?

Already done. I wonder if we should perhaps have an Areca Phabricator group?

Closed by commit rS367948: arcmsr(4): don't bzero newly allocated ccb; xpt_alloc_ccb() already does that. (authored by trasz). · Explain WhyNov 23 2020, 12:51 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS367948: arcmsr(4): don't bzero newly allocated ccb; xpt_alloc_ccb() already does that..

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

arcmsr/

arcmsr.c

1 line

Diff 79882

View Options

head/sys/dev/arcmsr/arcmsr.c

arcmsr(4): don't bzero newly allocated ccbClosedPublicActions