Fix various warnings with higher WARNS.
ClosedPublic
Actions

Authored by jhb on Oct 13 2020, 6:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 14, 7:50 AM

	Unknown Object (File)
	Tue, Jun 9, 2:46 AM

	Unknown Object (File)
	Sun, Jun 7, 6:11 AM

	Unknown Object (File)
	Apr 27 2026, 11:09 AM

	Unknown Object (File)
	Apr 18 2026, 9:11 PM

	Unknown Object (File)
	Apr 7 2026, 8:45 PM

	Unknown Object (File)
	Apr 5 2026, 10:31 AM

	Unknown Object (File)
	Mar 30 2026, 3:59 AM

View All 83 Files

Subscribers

imp

Details

Reviewers

markj
kevans

Commits

rS366687: Fix various warnings with higher WARNS.

Summary

Rename global 'crid' to 'requested_crid' to avoid shadowing.
Remove some unused function arguments.
Use __DECONST().

Test Plan

tried to use this this week and it failed to build, presumably due to WARNS' default changing to 6 globally

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 34138
Build 31298: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 13 2020, 6:58 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2020, 6:58 PM

jhb requested review of this revision.Oct 13 2020, 6:58 PM

Harbormaster completed remote builds in B34138: Diff 78180.Oct 13 2020, 6:58 PM

kevans accepted this revision.Oct 13 2020, 7:22 PM

This revision is now accepted and ready to land.Oct 13 2020, 7:22 PM

markj accepted this revision.Oct 13 2020, 7:45 PM

jhb closed this revision.Oct 13 2020, 10:20 PM

jhb added a commit: rS366687: Fix various warnings with higher WARNS..

Revision Contents
Changeset List

Path

Size

tools/

crypto/

cryptocheck.c

117 lines

Diff 78180

View Options

tools/tools/crypto/cryptocheck.c

Fix various warnings with higher WARNS.ClosedPublicActions