Handle kmod local relocation failures gracefully
ClosedPublic
Actions

Authored by mhorne on Oct 6 2020, 10:17 PM.

Details

Reviewers

kib
markj

Commits

rS366526: Handle kmod local relocation failures gracefully

Summary

It is possible for elf_reloc_local() to fail in the unlikely case of
an unsupported relocation type. If this occurs, do not continue to
process the file. Also, print the symbol index as a hint to the user.

While here, make a couple of minor style adjustments.

If this version seems fine I will extend it to other architectures.

Test Plan

Forcing an unrecognized rtype causes kldload(8) to exit early.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Oct 6 2020, 10:17 PM

mhorne created this revision.

Harbormaster completed remote builds in B34027: Diff 77959.Oct 6 2020, 10:17 PM

markj accepted this revision.Oct 6 2020, 10:26 PM

This revision is now accepted and ready to land.Oct 6 2020, 10:26 PM

Go ahead with style/printf changes in amd64/elf_machdep.c in advance.

sys/kern/link_elf_obj.c
1683 ↗	(On Diff #77959)	Why ENOENT and not ENOEXEC ?

mhorne added inline comments.Oct 6 2020, 11:30 PM

sys/kern/link_elf_obj.c
1683 ↗	(On Diff #77959)	I wasn't sure of the exact usage of ENOEXEC, but it does seem more appropriate here. Will update.

mhorne mentioned this in rS366519: Print symbol index for unsupported relocation types.Oct 7 2020, 6:48 PM

Update after r366519. Return ENOEXEC rather than ENOENT.

This revision now requires review to proceed.Oct 7 2020, 6:50 PM

Harbormaster completed remote builds in B34042: Diff 77984.Oct 7 2020, 6:50 PM

kib accepted this revision.Oct 7 2020, 6:55 PM

This revision is now accepted and ready to land.Oct 7 2020, 6:55 PM

Closed by commit rS366526: Handle kmod local relocation failures gracefully (authored by mhorne). · Explain WhyOct 7 2020, 11:15 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS366526: Handle kmod local relocation failures gracefully.

Herald added a subscriber: imp. · View Herald TranscriptOct 7 2020, 11:15 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

link_elf_obj.c

16 lines

Diff 77999

View Options

head/sys/kern/link_elf_obj.c

Handle kmod local relocation failures gracefullyClosedPublicActions