Page MenuHomeFreeBSD
Differential D2665

Remove several write-only variables.
ClosedPublic
Actions

Authored by kib on May 28 2015, 4:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 16, 9:56 PM
Unknown Object (File)
Fri, Aug 14, 7:16 PM
Unknown Object (File)
Thu, Aug 13, 2:58 PM
Unknown Object (File)
Thu, Aug 13, 1:07 PM
Unknown Object (File)
Wed, Aug 12, 12:27 PM
Unknown Object (File)
Wed, Aug 12, 3:32 AM
Unknown Object (File)
Mon, Aug 10, 5:17 PM
Unknown Object (File)
Sun, Aug 9, 8:03 PM
View All Files
Subscribers
bjk
imp
• rodrigc

Details

Reviewers
• rodrigc
Summary

Remove several write-only variables, all found by gcc 4.9 runs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib updated this revision to Diff 5751.May 28 2015, 4:49 PM
kib retitled this revision from to Remove several write-only variables..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMay 28 2015, 4:49 PM
• rodrigc accepted this revision.May 29 2015, 12:52 AM
• rodrigc added a reviewer: • rodrigc.
• rodrigc added a subscriber: • rodrigc.

Looks OK.

This revision is now accepted and ready to land.May 29 2015, 12:52 AM
bjk added a subscriber: bjk.May 29 2015, 1:05 AM

These all seem fine, though I do not claim sufficient familiarity with these parts of the code to be willing to actually mark the revision as 'accepted'.

kib closed this revision.Sep 22 2015, 3:02 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
6 lines
2 lines
ia32/
6 lines
dev/
pci/
14 lines
kern/
2 lines
6 lines
2 lines
4 lines
ufs/
ffs/
6 lines
2 lines
10 lines
14 lines
ufs/
2 lines
4 lines
x86/
iommu/
4 lines
8 lines

Diff 5751

View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/amd64/amd64/vm_machdep.c

Loading...
View Options

sys/amd64/ia32/ia32_reg.c

Loading...
View Options

sys/dev/pci/pci.c

Loading...
View Options

sys/kern/kern_exit.c

Loading...
View Options

sys/kern/kern_synch.c

Loading...
View Options

sys/kern/vfs_cluster.c

Loading...
View Options

sys/kern/vfs_init.c

Loading...
View Options

sys/ufs/ffs/ffs_softdep.c

Loading...
View Options

sys/ufs/ffs/ffs_suspend.c

Loading...
View Options

sys/ufs/ffs/ffs_vfsops.c

Loading...
View Options

sys/ufs/ffs/ffs_vnops.c

Loading...
View Options

sys/ufs/ufs/ufs_bmap.c

Loading...
View Options

sys/ufs/ufs/ufs_dirhash.c

Loading...
View Options

sys/x86/iommu/busdma_dmar.c

Loading...
View Options

sys/x86/iommu/intel_idpgtbl.c

Loading...