Differential D2665

Remove several write-only variables.
ClosedPublic
Actions

Authored by kib on May 28 2015, 4:49 PM.

Details

Reviewers

• rodrigc

Summary

Remove several write-only variables, all found by gcc 4.9 runs.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib updated this revision to Diff 5751.May 28 2015, 4:49 PM

kib retitled this revision from to Remove several write-only variables..

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMay 28 2015, 4:49 PM

Looks OK.

This revision is now accepted and ready to land.May 29 2015, 12:52 AM

These all seem fine, though I do not claim sufficient familiarity with these parts of the code to be willing to actually mark the revision as 'accepted'.

kib closed this revision.Sep 22 2015, 3:02 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

pmap.c

6 lines

vm_machdep.c

2 lines

ia32/

ia32_reg.c

6 lines

dev/

pci/

pci.c

14 lines

kern/

2 lines

6 lines

2 lines

4 lines

ufs/

ffs/

6 lines

2 lines

10 lines

14 lines

ufs/

ufs_bmap.c

2 lines

ufs_dirhash.c

4 lines

x86/

iommu/

busdma_dmar.c

4 lines

intel_idpgtbl.c

8 lines

Diff 5751

View Options

sys/amd64/amd64/pmap.c

View Options

sys/amd64/amd64/vm_machdep.c

View Options

sys/amd64/ia32/ia32_reg.c

View Options

sys/dev/pci/pci.c

View Options

sys/kern/kern_exit.c

View Options

sys/kern/kern_synch.c

View Options

sys/kern/vfs_cluster.c

View Options

sys/kern/vfs_init.c

View Options

sys/ufs/ffs/ffs_softdep.c

View Options

sys/ufs/ffs/ffs_suspend.c

View Options

sys/ufs/ffs/ffs_vfsops.c

View Options

sys/ufs/ffs/ffs_vnops.c

View Options

sys/ufs/ufs/ufs_bmap.c

View Options

sys/ufs/ufs/ufs_dirhash.c

View Options

sys/x86/iommu/busdma_dmar.c

View Options

sys/x86/iommu/intel_idpgtbl.c

Remove several write-only variables.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5751

sys/amd64/amd64/pmap.c

sys/amd64/amd64/vm_machdep.c

sys/amd64/ia32/ia32_reg.c

sys/dev/pci/pci.c

sys/kern/kern_exit.c

sys/kern/kern_synch.c

sys/kern/vfs_cluster.c

sys/kern/vfs_init.c

sys/ufs/ffs/ffs_softdep.c

sys/ufs/ffs/ffs_suspend.c

sys/ufs/ffs/ffs_vfsops.c

sys/ufs/ffs/ffs_vnops.c

sys/ufs/ufs/ufs_bmap.c

sys/ufs/ufs/ufs_dirhash.c

sys/x86/iommu/busdma_dmar.c

sys/x86/iommu/intel_idpgtbl.c

Remove several write-only variables.
ClosedPublic
Actions

Revision Contents
Changeset List