Page MenuHomeFreeBSD

ufs: restore uniqueness of st_dev
ClosedPublic

Authored by chs on Sep 29 2020, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 24, 7:13 PM
Unknown Object (File)
Thu, Sep 24, 6:58 PM
Unknown Object (File)
Thu, Sep 24, 4:55 PM
Unknown Object (File)
Thu, Sep 24, 5:05 AM
Unknown Object (File)
Sat, Sep 19, 8:51 AM
Unknown Object (File)
Thu, Sep 10, 3:47 AM
Unknown Object (File)
Aug 14 2026, 8:49 PM
Unknown Object (File)
Aug 11 2026, 4:47 PM
Subscribers

Details

Summary

the recently-added ufs_stat() sets st_dev to vp->v_mount->mnt_stat.f_fsid.val[0], but that value is not guaranteed to be unique, only the full 64-bit mnt_stat.f_fsid is guaranteed to be unique. ufs in particular stores the fsid in the superblock at newfs time, and the first 32-bit half is set to the time_t of when newfs was run, so if two file systems are newfs'd in the same second (easy to do with flash storage) then ufs_stat() will report the same st_dev for both file systems. this patch restores uniqueness of st_dev for ufs file systems by changing ufs_stat() to set st_dev to the same value that we used to get before the VOP_STAT() changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable