Makefile.inc1: sysent: allow subordinate sysent targets to run in parallel
ClosedPublic
Actions

Authored by kevans on Sep 29 2020, 8:57 PM.

Details

Reviewers

brooks
emaste

Commits

rS366275: Makefile.inc1: sysent: allow subordinate sysent targets to run in parallel

Summary

makesyscalls.lua (and indeed makesyscalls.sh) are both safe to be run in parallel, so let's do it.

This is a trivial difference because runtime per-target is pretty small, but I like seeing it run in parallel when my muscle memory types make -sj4.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Sep 29 2020, 8:57 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2020, 8:57 PM

kevans requested review of this revision.Sep 29 2020, 8:57 PM

Harbormaster completed remote builds in B33885: Diff 77651.Sep 29 2020, 8:57 PM

kevans retitled this revision from Makefile.inc1: sysent: run subordinate sysent targets in parallel to Makefile.inc1: sysent: allow subordinate sysent targets to run in parallel.Sep 29 2020, 9:11 PM

emaste added inline comments.Sep 29 2020, 9:47 PM

Makefile.inc1
1506 ↗	(On Diff #77651)	should sysent still be `.PHONY`

brooks accepted this revision.Sep 29 2020, 10:09 PM

This revision is now accepted and ready to land.Sep 29 2020, 10:09 PM

kevans added inline comments.Sep 30 2020, 12:10 AM

Makefile.inc1
1506 ↗	(On Diff #77651)	Admittedly, I have no idea. It doesn't seem to make a difference based on `make -dm` output with and without, presumably because it still needs to examine the dependencies anyways and those are .PHONY. I'm going to err on the side of leaving it in because it can't hurt and punt it to further cleanup later if someone wants to. I will not remove it pre-commit.