Fix compat32 on mips64
ClosedPublic
Actions

Authored by jhibbits on Sep 25 2020, 4:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 6, 1:39 PM

	Unknown Object (File)
	Sun, Jul 5, 1:20 PM

	Unknown Object (File)
	Sun, Jul 5, 5:00 AM

	Unknown Object (File)
	Fri, Jun 26, 9:05 PM

	Unknown Object (File)
	Tue, Jun 23, 9:04 PM

	Unknown Object (File)
	Tue, Jun 16, 5:04 AM

	Unknown Object (File)
	Mon, Jun 15, 8:45 AM

	Unknown Object (File)
	Sat, Jun 13, 6:39 AM

View All Files

Subscribers

imp

Details

Reviewers

adrian
brooks

Group Reviewers

MIPS

Commits

rS366162: Fix compat32 on mips64

Summary

Two bugs:

Elf32_Auxinfo is broken, using pointers in the union, which are 64-bits not 32.
freebsd32_sysarch() doesn't update the 'user local' register when handling MIPS_SET_TLS, leading to a NULL pointer dereference in the 32-bit application.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Sep 25 2020, 4:37 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 25 2020, 4:37 PM

jhibbits requested review of this revision.Sep 25 2020, 4:37 PM

Harbormaster completed remote builds in B33815: Diff 77525.Sep 25 2020, 4:37 PM

brooks accepted this revision.Sep 25 2020, 4:58 PM

This revision is now accepted and ready to land.Sep 25 2020, 4:58 PM

Closed by commit rS366162: Fix compat32 on mips64 (authored by jhibbits). · Explain WhySep 25 2020, 5:14 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rS366162: Fix compat32 on mips64.

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

include/

elf.h

2 lines

mips/

freebsd32_machdep.c

12 lines

Diff 77530

View Options

head/sys/mips/include/elf.h