Page MenuHomeFreeBSD

Misc compiler warning fixes in lib/libc
ClosedPublic

Authored by asomers on Sep 23 2020, 6:12 PM.
Tags
None
Referenced Files
F132736270: D26534.id.diff
Sun, Oct 19, 11:56 AM
Unknown Object (File)
Sat, Oct 18, 4:34 PM
Unknown Object (File)
Sat, Oct 18, 5:37 AM
Unknown Object (File)
Sat, Oct 18, 5:36 AM
Unknown Object (File)
Sat, Oct 18, 5:36 AM
Unknown Object (File)
Fri, Oct 17, 6:58 PM
Unknown Object (File)
Thu, Oct 9, 3:53 PM
Unknown Object (File)
Thu, Oct 9, 9:36 AM
Subscribers

Details

Summary

Misc compiler warning fixes in lib/libc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33818
Build 31035: arc lint + arc unit

Event Timeline

lib/libc/gen/auxv.c
276

Shouldn't we declare buflen to be a size_t instead?

lib/libc/gen/auxv.c
276

Can't, because _elf_aux_info must have the same signature as elf_aux_info

lib/libc/gen/auxv.c
276

Then maybe we should widen buflen to size_t instead of narrowing the return value of strlcpy.

btw, the rest of the changes look totally fine. Sorry to be so nitpicky over this one...

lib/libc/gen/auxv.c
276

and do we need to make sure buflen isn't less than zero?

asomers marked 3 inline comments as done.

Handle buflen more carefully in _elf_aux_info

kevans added inline comments.
lib/libc/gen/auxv.c
276

I would've perhaps opted to just widen it for this one comparison after checking that it's not negative above, but I think it's fine either way.

This revision is now accepted and ready to land.Sep 25 2020, 7:11 PM
This revision was automatically updated to reflect the committed changes.