Page MenuHomeFreeBSD
Differential D26534

Misc compiler warning fixes in lib/libc
ClosedPublic
Actions

Authored by asomers on Sep 23 2020, 6:12 PM.

Details

Reviewers
kevans
Commits
rS366207: Misc compiler warning fixes in lib/libc
Summary

Misc compiler warning fixes in lib/libc

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Sep 23 2020, 6:12 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 23 2020, 6:12 PM
asomers requested review of this revision.Sep 23 2020, 6:12 PM
Harbormaster completed remote builds in B33776: Diff 77447.Sep 23 2020, 6:12 PM
imp added inline comments.Sep 23 2020, 7:42 PM
lib/libc/gen/auxv.c
270 ↗(On Diff #77447)

Shouldn't we declare buflen to be a size_t instead?

asomers added inline comments.Sep 23 2020, 8:24 PM
lib/libc/gen/auxv.c
270 ↗(On Diff #77447)

Can't, because _elf_aux_info must have the same signature as elf_aux_info

imp added inline comments.Sep 23 2020, 11:15 PM
lib/libc/gen/auxv.c
270 ↗(On Diff #77447)

Then maybe we should widen buflen to size_t instead of narrowing the return value of strlcpy.

imp added a comment.Sep 23 2020, 11:19 PM

btw, the rest of the changes look totally fine. Sorry to be so nitpicky over this one...

lib/libc/gen/auxv.c
270 ↗(On Diff #77447)

and do we need to make sure buflen isn't less than zero?

asomers updated this revision to Diff 77537.Fri, Sep 25, 7:04 PM
asomers marked 3 inline comments as done.

Handle buflen more carefully in _elf_aux_info

Harbormaster completed remote builds in B33818: Diff 77537.Fri, Sep 25, 7:04 PM
kevans accepted this revision.Fri, Sep 25, 7:11 PM
kevans added inline comments.
lib/libc/gen/auxv.c
270 ↗(On Diff #77447)

I would've perhaps opted to just widen it for this one comparison after checking that it's not negative above, but I think it's fine either way.

This revision is now accepted and ready to land.Fri, Sep 25, 7:11 PM
Closed by commit rS366207: Misc compiler warning fixes in lib/libc (authored by asomers). · Explain WhySun, Sep 27, 10:27 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS366207: Misc compiler warning fixes in lib/libc.

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
gen/
34 lines
3 lines
5 lines
2 lines
5 lines
3 lines
1 line

Diff 77578

View Options

head/lib/libc/gen/auxv.c

Loading...
View Options

head/lib/libc/gen/basename_compat.c

Loading...
View Options

head/lib/libc/gen/crypt.c

Loading...
View Options

head/lib/libc/gen/dirname_compat.c

Loading...
View Options

head/lib/libc/gen/fts-compat.c

Loading...
View Options

head/lib/libc/gen/ftw-compat11.c

Loading...
View Options

head/lib/libc/gen/getentropy.c

Loading...