Page MenuHomeFreeBSD

Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers
ClosedPublic

Authored by trasz on Wed, Sep 23, 1:50 PM.

Details

Summary

Make makesyscalls.lua initialize 'struct sysent' entries using c99
designated identifiers. This makes it easier to modify 'struct sysent'
layout.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz requested review of this revision.Wed, Sep 23, 1:50 PM
trasz added a reviewer: kevans.

Tagging Brooks in as well for Cheri perspective

Seems sensible. Those are going to be some long lines, but they aren't really meant to be read.

This revision is now accepted and ready to land.Wed, Sep 23, 4:55 PM
sys/tools/makesyscalls.lua
750 ↗(On Diff #77423)

All of these entries that we're initializing to 0 (maybe even NULL) should be able to go away now, no?

sys/tools/makesyscalls.lua
750 ↗(On Diff #77423)

Yeah, no need to keep them.

Drop some fields that were always 0 or NULL.

Technically I could drop some more (ie all '.sv_narg = 0'), but the output looked somewhat ugly and inconsistent.

This revision now requires review to proceed.Wed, Sep 23, 9:29 PM

Sure, that's reasonable- while we don't expect people to look at the output, it is good for it to look at least somewhat clean in case we need to sanity check it.

This revision is now accepted and ready to land.Wed, Sep 23, 9:32 PM