Page MenuHomeFreeBSD
Differential D26530

Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers
ClosedPublic
Actions

Authored by trasz on Sep 23 2020, 1:50 PM.
Tags
None
Referenced Files
F107213113: D26530.diff
Sat, Jan 11, 3:40 PM
Unknown Object (File)
Tue, Dec 24, 2:09 PM
Unknown Object (File)
Nov 27 2024, 6:57 PM
Unknown Object (File)
Oct 22 2024, 11:48 AM
Unknown Object (File)
Oct 14 2024, 3:08 PM
Unknown Object (File)
Oct 14 2024, 3:08 PM
Unknown Object (File)
Oct 14 2024, 3:08 PM
Unknown Object (File)
Oct 14 2024, 3:08 PM
View All 72 Files
Subscribers
imp

Details

Reviewers
kevans
brooks
Commits
rS366145: Make makesyscalls.lua initialize 'struct sysent' entries using c99
Summary

Make makesyscalls.lua initialize 'struct sysent' entries using c99
designated identifiers. This makes it easier to modify 'struct sysent'
layout.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Sep 23 2020, 1:50 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 23 2020, 1:50 PM
trasz requested review of this revision.Sep 23 2020, 1:50 PM
Harbormaster completed remote builds in B33764: Diff 77423.Sep 23 2020, 1:50 PM
trasz edited the test plan for this revision. (Show Details)Sep 23 2020, 2:01 PM
trasz added a reviewer: kevans.
kevans added a reviewer: brooks.Sep 23 2020, 2:02 PM

Tagging Brooks in as well for Cheri perspective

trasz mentioned this in D26508: Shrink sysent from 48 to 32 bytes.Sep 23 2020, 2:05 PM
brooks accepted this revision.Sep 23 2020, 4:55 PM

Seems sensible. Those are going to be some long lines, but they aren't really meant to be read.

This revision is now accepted and ready to land.Sep 23 2020, 4:55 PM
kevans added inline comments.Sep 23 2020, 5:03 PM
sys/tools/makesyscalls.lua
750 ↗(On Diff #77423)

All of these entries that we're initializing to 0 (maybe even NULL) should be able to go away now, no?

brooks added inline comments.Sep 23 2020, 5:42 PM
sys/tools/makesyscalls.lua
750 ↗(On Diff #77423)

Yeah, no need to keep them.

trasz updated this revision to Diff 77460.Sep 23 2020, 9:29 PM

Drop some fields that were always 0 or NULL.

Technically I could drop some more (ie all '.sv_narg = 0'), but the output looked somewhat ugly and inconsistent.

This revision now requires review to proceed.Sep 23 2020, 9:29 PM
Harbormaster completed remote builds in B33783: Diff 77460.Sep 23 2020, 9:30 PM
kevans accepted this revision.Sep 23 2020, 9:32 PM

Sure, that's reasonable- while we don't expect people to look at the output, it is good for it to look at least somewhat clean in case we need to sanity check it.

This revision is now accepted and ready to land.Sep 23 2020, 9:32 PM
Closed by commit rS366145: Make makesyscalls.lua initialize 'struct sysent' entries using c99 (authored by trasz). · Explain WhySep 25 2020, 9:34 AM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS366145: Make makesyscalls.lua initialize 'struct sysent' entries using c99.

Revision Contents
Changeset List

PathSize
head/
sys/
tools/
27 lines

Diff 77509

View Options

head/sys/tools/makesyscalls.lua

Loading...