Page MenuHomeFreeBSD
Differential D26462

Fix additional memory leak in process_mapfile
ClosedPublic
Actions

Authored by bret_ketchum_dell.com on Sep 17 2020, 4:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 24, 2:31 PM
Unknown Object (File)
Sat, Aug 8, 7:16 PM
Unknown Object (File)
Mon, Aug 3, 2:31 AM
Unknown Object (File)
Mon, Aug 3, 1:27 AM
Unknown Object (File)
Sun, Aug 2, 5:18 AM
Unknown Object (File)
Fri, Jul 31, 5:37 AM
Unknown Object (File)
Jul 26 2026, 12:06 PM
Unknown Object (File)
Jul 24 2026, 10:36 PM
View All Files
Subscribers
imp

Details

Reviewers
cem
emaste
vangyzen
Commits
rS365845: Fix additional memory leak in process_mapfile
Summary

Additional Coverity detected memory leak fix.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bret_ketchum_dell.com requested review of this revision.Sep 17 2020, 4:10 PM
bret_ketchum_dell.com created this revision.
vangyzen accepted this revision.Sep 17 2020, 6:02 PM
This revision is now accepted and ready to land.Sep 17 2020, 6:02 PM
emaste accepted this revision.Sep 17 2020, 6:18 PM
cem accepted this revision.Sep 17 2020, 6:20 PM

Thanks.

lib/libpmc/pmu-events/jevents.c
783–806 ↗(On Diff #77136)

If goto out is acceptable at ~786, maybe we can just do that here too and use a variable for the return value. This fix seems ok as-is, though. Either way.

Closed by commit rS365845: Fix additional memory leak in process_mapfile (authored by vangyzen). · Explain WhySep 17 2020, 6:25 PM
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rS365845: Fix additional memory leak in process_mapfile.
Herald added a subscriber: imp. · View Herald TranscriptSep 17 2020, 6:25 PM

Revision Contents
Changeset List

PathSize
head/
lib/
libpmc/
pmu-events/
2 lines

Diff 77156

View Options

head/lib/libpmc/pmu-events/jevents.c

Loading...