Page MenuHomeFreeBSD
Differential D2643

Add KTR tracing for some MI ptrace events.
ClosedPublic
Actions

Authored by jhb on May 25 2015, 12:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 24, 4:49 PM
Unknown Object (File)
Fri, May 23, 12:26 PM
Unknown Object (File)
Fri, May 23, 2:51 AM
Unknown Object (File)
Thu, May 22, 7:49 PM
Unknown Object (File)
Wed, May 21, 1:50 PM
Unknown Object (File)
Thu, May 15, 6:31 PM
Unknown Object (File)
Thu, May 15, 7:10 AM
Unknown Object (File)
Thu, May 15, 4:09 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS283546: Add KTR tracing for some MI ptrace events.
Summary

Add KTR tracing for some MI ptrace events.

Test Plan
  • I'm using this while debugging ptrace() bugs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

jhb updated this revision to Diff 5675.May 25 2015, 12:13 PM
jhb retitled this revision from to Add KTR tracing for some MI ptrace events..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: kib.
Herald added a subscriber: imp. · View Herald TranscriptMay 25 2015, 12:13 PM
kib edited edge metadata.May 25 2015, 12:43 PM

Should MD ptrace actions be traced as well ? I mean the ops handled in arch/arch/ptrace_machdep.c.

sys/kern/kern_exit.c
1224

Please, provide the stock p->p_xstat value there.

sys/kern/sys_process.c
884

Wouldn't previous follow-fork mode value also be useful there ?

jhb marked 2 inline comments as done.May 25 2015, 1:21 PM
In D2643#49325, @kib wrote:

Should MD ptrace actions be traced as well ? I mean the ops handled in arch/arch/ptrace_machdep.c.

I think so, though I would maybe add those later. I will probably add x86 in a follow up at least. For now my focus is on wait()'ing for child exit status (and the follow fork stuff) which is all MI.

sys/kern/kern_exit.c
1224

Ok, I will provide both as I think it is useful to also see the "cooked" status returned by wait.

jhb updated this revision to Diff 5687.May 25 2015, 4:39 PM
jhb marked an inline comment as done.
jhb edited edge metadata.
  • Two suggestions from kib@.
  • Compile.
kib accepted this revision.May 25 2015, 5:16 PM
kib edited edge metadata.
This revision is now accepted and ready to land.May 25 2015, 5:16 PM
Closed by commit rS283546: Add KTR tracing for some MI ptrace events. (authored by jhb). · Explain WhyMay 25 2015, 10:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
kern/
9 lines
3 lines
2 lines
75 lines
sys/
3 lines

Diff 5687

View Options

sys/kern/kern_exit.c

Loading...
View Options

sys/kern/kern_fork.c

Loading...
View Options

sys/kern/kern_sig.c

Loading...
View Options

sys/kern/sys_process.c

Loading...
View Options

sys/sys/ktr_class.h

Loading...