Page MenuHomeFreeBSD

Move TDP_GEOM check to ast()
ClosedPublic

Authored by trasz on Wed, Sep 9, 3:09 PM.

Details

Summary

Move TDP_GEOM check from userret() to ast(); it seems quite infrequent.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz created this revision.Wed, Sep 9, 3:09 PM
trasz requested review of this revision.Wed, Sep 9, 3:09 PM
trasz added reviewers: kib, mav.Wed, Sep 9, 3:09 PM
mav added a comment.Wed, Sep 9, 3:23 PM

It is indeed infrequent. I can't say much about the ast() context, but I have no objections.

kib added inline comments.Wed, Sep 9, 3:47 PM
sys/kern/subr_trap.c
291 ↗(On Diff #76812)

I am slightly unsure about place to put this sleep. It is fine for now, we will see if things break.

kib accepted this revision.Wed, Sep 9, 3:48 PM
This revision is now accepted and ready to land.Wed, Sep 9, 3:48 PM
trasz added a comment.Sun, Sep 13, 3:57 PM

(Tinderboxed, Tested by: pho)