Page MenuHomeFreeBSD
Differential D26369

Clean up gprof
ClosedPublic
Actions

Authored by andrew on Sep 9 2020, 10:24 AM.
Tags
None
Referenced Files
F167096417: D26369.id76801.diff
Wed, Aug 19, 1:39 AM
Unknown Object (File)
Tue, Aug 18, 10:05 PM
Unknown Object (File)
Tue, Aug 18, 9:30 PM
Unknown Object (File)
Tue, Aug 18, 8:39 PM
Unknown Object (File)
Tue, Aug 18, 12:08 PM
Unknown Object (File)
Sun, Aug 16, 3:50 AM
Unknown Object (File)
Sat, Aug 15, 4:26 AM
Unknown Object (File)
Fri, Aug 14, 11:40 PM
View All Files
Subscribers
imp

Details

Reviewers
brooks
brett-gutstein
Commits
rS365727: Cleanups for gprof:
Summary
  • Remove identical or almost identical headers
  • List the architectures where aout.c builds rather than where to not build it
  • Enable on all architectures

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Sep 9 2020, 10:24 AM
andrew created this revision.
Harbormaster completed remote builds in B33452: Diff 76801.Sep 9 2020, 10:24 AM
andrew edited the summary of this revision. (Show Details)Sep 9 2020, 10:26 AM
andrew added reviewers: brooks, brett-gutstein.Sep 9 2020, 10:34 AM
imp added a subscriber: imp.Sep 9 2020, 3:55 PM
imp added inline comments.
usr.bin/gprof/Makefile
8 ↗(On Diff #76801)

We switched to ELF in FreeBSD 3.2. which means only i386 ever had a.out (though there were prototypes for FreeBSD/alpha with a.out iirc, that's not relevant here).

This should read simply

.if ${MACHINE_CPUARCH} == "i386"

andrew added inline comments.Sep 9 2020, 4:16 PM
usr.bin/gprof/Makefile
8 ↗(On Diff #76801)

<kib> we support i386 a.out on amd64 s/we/I/

andrew updated this revision to Diff 76820.EditedSep 9 2020, 4:16 PM

Only support aout.c on i386 & amd64

Harbormaster completed remote builds in B33464: Diff 76820.Sep 9 2020, 4:16 PM
imp added a comment.Sep 9 2020, 6:32 PM
In D26369#586493, @andrew wrote:

Only support aout.c on i386 & amd64

Crazy question: Do we support building and profiling a.out even at all? Maybe we just drop it entirely?

andrew added a comment.Sep 9 2020, 8:26 PM

I have no idea, although if we remove it I think it should be a second change that could be easily reverted if needed.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2020, 4:19 PM
Closed by commit rS365727: Cleanups for gprof: (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rS365727: Cleanups for gprof:.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
4 lines
gprof/
3 lines
42 lines
42 lines
29 lines
42 lines
48 lines
42 lines
41 lines
42 lines

Diff 77015

View Options

head/usr.bin/Makefile

Loading...
View Options

head/usr.bin/gprof/Makefile

Loading...
View Options

head/usr.bin/gprof/amd64.h

Loading...
View Options

head/usr.bin/gprof/arm.h

Loading...
View Options

head/usr.bin/gprof/gprof.h

Loading...
View Options

head/usr.bin/gprof/i386.h

Loading...
View Options

head/usr.bin/gprof/mips.h

Loading...
View Options

head/usr.bin/gprof/powerpc.h

Loading...
View Options

head/usr.bin/gprof/riscv.h

Loading...
View Options

head/usr.bin/gprof/sparc64.h

Loading...