Page MenuHomeFreeBSD

Clean up gprof
ClosedPublic

Authored by andrew on Sep 9 2020, 10:24 AM.
Tags
None
Referenced Files
F81920821: D26369.id77015.diff
Tue, Apr 23, 5:09 AM
Unknown Object (File)
Mar 2 2024, 12:56 PM
Unknown Object (File)
Feb 1 2024, 9:58 PM
Unknown Object (File)
Dec 20 2023, 2:48 AM
Unknown Object (File)
Jul 31 2023, 10:23 PM
Unknown Object (File)
Jul 6 2023, 9:27 AM
Unknown Object (File)
May 13 2023, 10:41 AM
Subscribers

Details

Summary
  • Remove identical or almost identical headers
  • List the architectures where aout.c builds rather than where to not build it
  • Enable on all architectures

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.
imp added inline comments.
usr.bin/gprof/Makefile
8 ↗(On Diff #76801)

We switched to ELF in FreeBSD 3.2. which means only i386 ever had a.out (though there were prototypes for FreeBSD/alpha with a.out iirc, that's not relevant here).

This should read simply

.if ${MACHINE_CPUARCH} == "i386"

usr.bin/gprof/Makefile
8 ↗(On Diff #76801)

<kib> we support i386 a.out on amd64 s/we/I/

Only support aout.c on i386 & amd64

Only support aout.c on i386 & amd64

Crazy question: Do we support building and profiling a.out even at all? Maybe we just drop it entirely?

I have no idea, although if we remove it I think it should be a second change that could be easily reverted if needed.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2020, 4:19 PM
Closed by commit rS365727: Cleanups for gprof: (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.