Page MenuHomeFreeBSD

Clean up gprof
ClosedPublic

Authored by andrew on Wed, Sep 9, 10:24 AM.

Details

Summary
  • Remove identical or almost identical headers
  • List the architectures where aout.c builds rather than where to not build it
  • Enable on all architectures

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

andrew requested review of this revision.Wed, Sep 9, 10:24 AM
andrew created this revision.
andrew edited the summary of this revision. (Show Details)Wed, Sep 9, 10:26 AM
imp added a subscriber: imp.Wed, Sep 9, 3:55 PM
imp added inline comments.
usr.bin/gprof/Makefile
8 ↗(On Diff #76801)

We switched to ELF in FreeBSD 3.2. which means only i386 ever had a.out (though there were prototypes for FreeBSD/alpha with a.out iirc, that's not relevant here).

This should read simply

.if ${MACHINE_CPUARCH} == "i386"

andrew added inline comments.Wed, Sep 9, 4:16 PM
usr.bin/gprof/Makefile
8 ↗(On Diff #76801)

<kib> we support i386 a.out on amd64 s/we/I/

andrew updated this revision to Diff 76820.EditedWed, Sep 9, 4:16 PM

Only support aout.c on i386 & amd64

imp added a comment.Wed, Sep 9, 6:32 PM

Only support aout.c on i386 & amd64

Crazy question: Do we support building and profiling a.out even at all? Maybe we just drop it entirely?

andrew added a comment.Wed, Sep 9, 8:26 PM

I have no idea, although if we remove it I think it should be a second change that could be easily reverted if needed.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 14, 4:19 PM
Closed by commit rS365727: Cleanups for gprof: (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.