Avoid collisions with function names in openssl headers.
ClosedPublic
Actions

Authored by stevek on Sep 4 2020, 2:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 17, 1:17 PM

	Unknown Object (File)
	Fri, Apr 17, 1:12 PM

	Unknown Object (File)
	Wed, Apr 15, 9:03 AM

	Unknown Object (File)
	Tue, Apr 14, 7:46 AM

	Unknown Object (File)
	Wed, Apr 8, 9:33 PM

	Unknown Object (File)
	Mon, Apr 6, 3:37 AM

	Unknown Object (File)
	Sat, Apr 4, 10:49 PM

	Unknown Object (File)
	Sat, Apr 4, 2:29 PM

View All Files

Subscribers

imp

Details

Reviewers

brooks
sjg

Commits

rS365325: Avoid collisions with function names in openssl headers.

Summary

Just using MD5, SHA1, RMD160 and SHA256 for defines collides with
functions of the same name in OpenSSL. This can cause compilation
issues in downstream consumers if they use OpenSSL for the hash
functions instead of libmd.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

stevek created this revision.Sep 4 2020, 2:45 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 4 2020, 2:45 AM

stevek requested review of this revision.Sep 4 2020, 2:45 AM

Harbormaster completed remote builds in B33377: Diff 76634.Sep 4 2020, 2:45 AM

sjg accepted this revision.Sep 4 2020, 2:52 AM

This revision is now accepted and ready to land.Sep 4 2020, 2:52 AM

Closed by commit rS365325: Avoid collisions with function names in openssl headers. (authored by stevek). · Explain WhySep 4 2020, 4:32 AM

This revision was automatically updated to reflect the committed changes.

stevek added a commit: rS365325: Avoid collisions with function names in openssl headers..

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

fmtree/

Makefile

2 lines

compare.c

16 lines

Diff 76635

View Options

head/usr.sbin/fmtree/Makefile