Page MenuHomeFreeBSD
Differential D26289

Remove risky compatability with old kernels.
ClosedPublic
Actions

Authored by brooks on Sep 1 2020, 10:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 21, 9:51 AM
Unknown Object (File)
Tue, Jul 21, 8:20 AM
Unknown Object (File)
Mon, Jul 20, 3:40 AM
Unknown Object (File)
Sat, Jul 18, 3:30 PM
Unknown Object (File)
Sat, Jul 4, 1:46 PM
Unknown Object (File)
Sat, Jul 4, 1:42 PM
Unknown Object (File)
Sat, Jul 4, 10:16 AM
Unknown Object (File)
Sat, Jul 4, 10:13 AM
View All Files
Subscribers
None

Details

Reviewers
mckusick
imp
kevans
Commits
rS365534: MFC r365279:
rS365519: MFC r365279:
rS365279: Remove risky compatability with old kernels
Summary

The badsys() handler for SIGSYS was added as a transtion aid for kernels
lacking sysctl() in 1993. It is unsafe and unsound so remove it rather
than running the risk of a privilege-dropping system call being silently
omitted.

This partially reverts SCCSID 6.12 (Berkeley) 03/03/93 "add code to
change the system security level".

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks requested review of this revision.Sep 1 2020, 10:26 PM
brooks created this revision.
Harbormaster completed remote builds in B33315: Diff 76519.Sep 1 2020, 10:26 PM
brooks added a comment.Sep 1 2020, 10:27 PM

For reverence the original commit is https://svnweb.freebsd.org/csrg?view=revision&revision=58422

brooks added a comment.Sep 1 2020, 10:29 PM

I found this when discussing the implications of D26288.

mckusick accepted this revision.Sep 1 2020, 11:17 PM

It was a horrible hack at the time and should have been tossed decades ago.

This revision is now accepted and ready to land.Sep 1 2020, 11:17 PM
imp accepted this revision.Sep 2 2020, 3:52 AM

Kill it with fire

kevans accepted this revision.Sep 2 2020, 1:26 PM
Closed by commit rS365279: Remove risky compatability with old kernels (authored by brooks). · Explain WhySep 2 2020, 9:14 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rS365279: Remove risky compatability with old kernels.
brooks added a commit: rS365519: MFC r365279:.Sep 9 2020, 9:58 PM
brooks added a commit: rS365534: MFC r365279:.Sep 9 2020, 10:40 PM

Revision Contents
Changeset List

PathSize
head/
sbin/
init/
22 lines

Diff 76567

View Options

head/sbin/init/init.c

Loading...