Remove risky compatability with old kernels.
ClosedPublic
Actions

Authored by brooks on Sep 1 2020, 10:26 PM.

Details

Reviewers

mckusick
imp
kevans

Commits

rS365534: MFC r365279:
rS365519: MFC r365279:
rS365279: Remove risky compatability with old kernels

Summary

The badsys() handler for SIGSYS was added as a transtion aid for kernels
lacking sysctl() in 1993. It is unsafe and unsound so remove it rather
than running the risk of a privilege-dropping system call being silently
omitted.

This partially reverts SCCSID 6.12 (Berkeley) 03/03/93 "add code to
change the system security level".

Diff Detail

Repository

rS FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brooks requested review of this revision.Sep 1 2020, 10:26 PM

brooks created this revision.

Harbormaster completed remote builds in B33315: Diff 76519.Sep 1 2020, 10:26 PM

For reverence the original commit is https://svnweb.freebsd.org/csrg?view=revision&revision=58422

I found this when discussing the implications of D26288.

It was a horrible hack at the time and should have been tossed decades ago.

This revision is now accepted and ready to land.Sep 1 2020, 11:17 PM

Kill it with fire

kevans accepted this revision.Sep 2 2020, 1:26 PM

Closed by commit rS365279: Remove risky compatability with old kernels (authored by brooks). · Explain WhySep 2 2020, 9:14 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS365279: Remove risky compatability with old kernels.

brooks added a commit: rS365519: MFC r365279:.Sep 9 2020, 9:58 PM

brooks added a commit: rS365534: MFC r365279:.Sep 9 2020, 10:40 PM

Revision Contents
Changeset List

Path

Size

head/

sbin/

init/

init.c

22 lines

Diff 76567

View Options

Remove risky compatability with old kernels.ClosedPublicActions