Differential D26247

Fix string overflow
ClosedPublic
Actions

Authored by trasz on Aug 31 2020, 1:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 8, 12:50 PM

	Unknown Object (File)
	Mon, Sep 7, 7:56 AM

	Unknown Object (File)
	Sun, Sep 6, 6:00 AM

	Unknown Object (File)
	Sat, Sep 5, 1:29 AM

	Unknown Object (File)
	Fri, Sep 4, 2:10 AM

	Unknown Object (File)
	Thu, Sep 3, 5:07 PM

	Unknown Object (File)
	Thu, Sep 3, 5:05 PM

	Unknown Object (File)
	Wed, Sep 2, 2:03 AM

Subscribers

siderop1_netapp.com

Details

Reviewers

Commits

rS365040: Fix string overflow that could occur during redirection due to passing

Summary

Fix string overflow that could occur during redirection by passing
the right length to strlcpy(3). It looks like it could overflow
into the next field, isc_user, which is properly long to accomodate
for it; I don't think it could cause any harm other than breaking
the connection.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Aug 31 2020, 1:54 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2020, 1:54 PM

trasz requested review of this revision.Aug 31 2020, 1:54 PM

Harbormaster completed remote builds in B33251: Diff 76397.Aug 31 2020, 1:54 PM

trasz added a reviewer: mav.Aug 31 2020, 2:09 PM

trasz edited the summary of this revision. (Show Details)Aug 31 2020, 2:23 PM

mav accepted this revision.Aug 31 2020, 2:29 PM

This revision is now accepted and ready to land.Aug 31 2020, 2:29 PM

allanjude added a subscriber: siderop1_netapp.com.Aug 31 2020, 3:13 PM

Closed by commit rS365040: Fix string overflow that could occur during redirection due to passing (authored by trasz). · Explain WhySep 1 2020, 2:52 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS365040: Fix string overflow that could occur during redirection due to passing.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

iscsid/

2 lines

Diff 76484

head/usr.sbin/iscsid/login.c

Loading...