Fix memory leak in diffreg
ClosedPublic
Actions

Authored by bret_ketchum_dell.com on Aug 29 2020, 6:27 PM.

Tags

None

Referenced Files

	F132314928: D26232.id.diff
	Wed, Oct 15, 7:47 PM

	F132314927: D26232.id76344.diff
	Wed, Oct 15, 7:47 PM

	Unknown Object (File)
	Wed, Oct 15, 9:27 AM

	Unknown Object (File)
	Wed, Oct 15, 9:27 AM

	Unknown Object (File)
	Wed, Oct 15, 9:27 AM

	Unknown Object (File)
	Tue, Oct 14, 10:49 PM

	Unknown Object (File)
	Thu, Sep 18, 12:37 AM

	Unknown Object (File)
	Sep 9 2025, 10:56 AM

View All 67 Files

Subscribers

imp

Details

Reviewers

bapt
vangyzen

Commits

rS365041: diff: always properly kill pr(1)

Summary

Coverity detected memory leak fix.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bret_ketchum_dell.com requested review of this revision.Aug 29 2020, 6:27 PM

bret_ketchum_dell.com created this revision.

Thank you, note this is not a memory leak, rather process leak (?)

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2020, 2:52 PM

Closed by commit rS365041: diff: always properly kill pr(1) (authored by bapt). · Explain Why

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rS365041: diff: always properly kill pr(1).

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2020, 2:52 PM

bapt mentioned this in rS365914: MFC r361688-r361690, r365041.Sep 19 2020, 8:16 PM

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

diff/

diffreg.c

6 lines

Diff 76485

View Options

head/usr.bin/diff/diffreg.c

Fix memory leak in diffregClosedPublicActions