Fix memory leak in process_mapfile
ClosedPublic
Actions

Authored by bret_ketchum_dell.com on Aug 29 2020, 4:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 20, 7:54 PM

	Unknown Object (File)
	Mon, Oct 20, 7:54 PM

	Unknown Object (File)
	Mon, Oct 20, 7:54 PM

	Unknown Object (File)
	Mon, Oct 20, 7:54 PM

	Unknown Object (File)
	Mon, Oct 20, 7:54 PM

	Unknown Object (File)
	Mon, Oct 20, 7:58 AM

	Unknown Object (File)
	Sat, Oct 18, 9:43 PM

	Unknown Object (File)
	Sat, Oct 4, 5:48 AM

View All Files

Subscribers

imp

Details

Reviewers

cem
vangyzen

Commits

rS364996: libpmc: Fix memory leak in process_mapfile

Summary

Coverity detected memory leak fix.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bret_ketchum_dell.com requested review of this revision.Aug 29 2020, 4:27 PM

bret_ketchum_dell.com created this revision.

cem accepted this revision.Aug 29 2020, 7:00 PM

This revision is now accepted and ready to land.Aug 29 2020, 7:00 PM

Explicitly close the stream to appease the static analyzer.

This revision now requires review to proceed.Aug 29 2020, 7:11 PM

cem added inline comments.Aug 29 2020, 8:24 PM

lib/libpmc/pmu-events/jevents.c
789–797 ↗	(On Diff #76346)	line is leaked here

Fix another leak.

Thanks!

This revision is now accepted and ready to land.Aug 30 2020, 2:34 PM

Closed by commit rS364996: libpmc: Fix memory leak in process_mapfile (authored by vangyzen). · Explain WhyAug 31 2020, 4:07 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rS364996: libpmc: Fix memory leak in process_mapfile.

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2020, 4:07 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libpmc/

pmu-events/

jevents.c

3 lines

Diff 76418

View Options

head/lib/libpmc/pmu-events/jevents.c

Fix memory leak in process_mapfileClosedPublicActions