Page MenuHomeFreeBSD
Differential D2621

Properly update TX statistics for wlan(4)
ClosedPublic
Actions

Authored by ae on May 22 2015, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 7:29 AM
Unknown Object (File)
Sun, Jan 12, 2:08 PM
Unknown Object (File)
Dec 5 2024, 4:17 PM
Unknown Object (File)
Nov 28 2024, 8:28 PM
Unknown Object (File)
Nov 28 2024, 6:09 AM
Unknown Object (File)
Nov 19 2024, 4:48 AM
Unknown Object (File)
Nov 17 2024, 12:22 AM
Unknown Object (File)
Nov 12 2024, 11:45 AM
View All Files
Subscribers
imp

Details

Reviewers
adrian
Group Reviewers
network
Commits
rS283855: MFC r283313:
rS283313: Properly update TX statistics for wlan(4).
Summary

PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=184626
Currently we don't account TX statistics on wlan(4) interfaces. This patch add this accounting.
Since ieee80211_pwrsave() can fail due to queue overflow, check its return code and increment oerrors counter when it fails.
Update obytes and omcasts counters. It seems it is correct to save mbuf's lenght for incrementing obytes before calling ieee80211_encap().
Also update oerrors in case when we don't send mbuf due to some errors.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ae updated this revision to Diff 5556.May 22 2015, 2:30 PM
ae retitled this revision from to Properly update TX statistics for wlan(4).
ae updated this object.
ae edited the test plan for this revision. (Show Details)
ae added a reviewer: adrian.
ae set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMay 22 2015, 2:30 PM
ae added a reviewer: network.May 22 2015, 3:32 PM
adrian accepted this revision.May 23 2015, 2:57 AM
adrian edited edge metadata.

Looks fine to me, please commit!

Thanks for digging into this!

This revision is now accepted and ready to land.May 23 2015, 2:57 AM
Closed by commit rS283313: Properly update TX statistics for wlan(4). (authored by ae). · Explain WhyMay 23 2015, 9:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net80211/
23 lines
6 lines

Diff 5579

View Options

head/sys/net80211/ieee80211_output.c

Loading...
View Options

head/sys/net80211/ieee80211_wds.c

Loading...