Page MenuHomeFreeBSD

Properly update TX statistics for wlan(4)
ClosedPublic

Authored by ae on May 22 2015, 2:30 PM.

Details

Summary

PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=184626
Currently we don't account TX statistics on wlan(4) interfaces. This patch add this accounting.
Since ieee80211_pwrsave() can fail due to queue overflow, check its return code and increment oerrors counter when it fails.
Update obytes and omcasts counters. It seems it is correct to save mbuf's lenght for incrementing obytes before calling ieee80211_encap().
Also update oerrors in case when we don't send mbuf due to some errors.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ae updated this revision to Diff 5556.May 22 2015, 2:30 PM
ae retitled this revision from to Properly update TX statistics for wlan(4).
ae updated this object.
ae edited the test plan for this revision. (Show Details)
ae added a reviewer: adrian.
ae set the repository for this revision to rS FreeBSD src repository.
ae added a reviewer: network.May 22 2015, 3:32 PM
adrian accepted this revision.May 23 2015, 2:57 AM
adrian edited edge metadata.

Looks fine to me, please commit!

Thanks for digging into this!

This revision is now accepted and ready to land.May 23 2015, 2:57 AM
This revision was automatically updated to reflect the committed changes.