Page MenuHomeFreeBSD

contrib/nvi: fix -w option
ClosedPublic

Authored by fernape on Aug 22 2020, 5:55 PM.
Tags
None
Referenced Files
F164998414: D26158.id76090.diff
Wed, Aug 5, 6:53 AM
F164958684: D26158.id77712.diff
Wed, Aug 5, 3:10 AM
Unknown Object (File)
Mon, Aug 3, 1:31 PM
Unknown Object (File)
Sun, Aug 2, 12:58 AM
Unknown Object (File)
Sun, Jul 26, 3:32 PM
Unknown Object (File)
Tue, Jul 21, 8:13 AM
Unknown Object (File)
Mon, Jul 20, 10:06 PM
Unknown Object (File)
Wed, Jul 8, 10:29 AM

Details

Summary

Reported in PR 241985

Compose the "window=%s" option as a CHAR_T to be processed properly in
opts_set

Test Plan

Before the patch, trying this:

$ vi -w 10

shows an error:

set: no wo0 option: 'set all' gives all option values
Press Enter to continue:

And vi launches with as many lines as to fill the terminal screen

------------ BEGINING OF SCREEN

~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
------------ END OF SCREEN

After the patch, thre is no error

$ vi -w 10

and the vi screen is limited to the specified amount of lines:

------------ BEGINING OF SCREEN

~
~
~
~
~
~
~
~
~
------------ END OF SCREEN

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This one has been merged upstream

Should I withdraw this review?
What to do with the original PR?

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2020, 4:47 AM
Closed by commit rS366309: Update nvi to 2.2.0-05ed8b9 (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.