Page MenuHomeFreeBSD

contrib/nvi: fix -w option
ClosedPublic

Authored by fernape on Aug 22 2020, 5:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 10:48 AM
Unknown Object (File)
Feb 27 2024, 12:43 PM
Unknown Object (File)
Feb 23 2024, 9:30 PM
Unknown Object (File)
Feb 23 2024, 9:30 PM
Unknown Object (File)
Feb 23 2024, 9:30 PM
Unknown Object (File)
Feb 23 2024, 6:42 PM
Unknown Object (File)
Feb 6 2024, 10:34 PM
Unknown Object (File)
Jan 7 2024, 3:35 AM

Details

Summary

Reported in PR 241985

Compose the "window=%s" option as a CHAR_T to be processed properly in
opts_set

Test Plan

Before the patch, trying this:

$ vi -w 10

shows an error:

set: no wo0 option: 'set all' gives all option values
Press Enter to continue:

And vi launches with as many lines as to fill the terminal screen

------------ BEGINING OF SCREEN

~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
------------ END OF SCREEN

After the patch, thre is no error

$ vi -w 10

and the vi screen is limited to the specified amount of lines:

------------ BEGINING OF SCREEN

~
~
~
~
~
~
~
~
~
------------ END OF SCREEN

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This one has been merged upstream

Should I withdraw this review?
What to do with the original PR?

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2020, 4:47 AM
Closed by commit rS366309: Update nvi to 2.2.0-05ed8b9 (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.