Page MenuHomeFreeBSD

[PowerPC] Move pmc_hook out of critical section
ClosedPublic

Authored by luporl on Aug 18 2020, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 20, 9:34 PM
Unknown Object (File)
Sat, Jun 14, 3:49 PM
Unknown Object (File)
Wed, Jun 11, 9:40 PM
Unknown Object (File)
Mon, Jun 9, 3:37 PM
Unknown Object (File)
Sun, Jun 8, 3:58 PM
Unknown Object (File)
Sun, Jun 8, 3:36 PM
Unknown Object (File)
Sat, Jun 7, 3:35 PM
Unknown Object (File)
May 26 2025, 6:26 PM
Subscribers

Details

Summary

Calling pmc_hook inside a critical section may result in a panic.

This happens when the user callchain is fetched, because it uses pmap_map_user_ptr, that tries to get the (sleepable) pmap lock when the needed vsid is not found.

Judging by the implementation in other platforms, intr_irq_handler in kern/subr_intr.c and what pmc_hook do, it seems safe to move pmc_hook outside the critical section.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable