Page MenuHomeFreeBSD

[PowerPC] Move pmc_hook out of critical section
ClosedPublic

Authored by luporl on Aug 18 2020, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 5, 7:06 AM
Unknown Object (File)
Wed, Apr 29, 9:50 PM
Unknown Object (File)
Wed, Apr 29, 6:15 AM
Unknown Object (File)
Wed, Apr 29, 6:09 AM
Unknown Object (File)
Sun, Apr 26, 12:03 AM
Unknown Object (File)
Tue, Apr 21, 1:01 AM
Unknown Object (File)
Mon, Apr 20, 6:07 AM
Unknown Object (File)
Thu, Apr 16, 3:26 PM
Subscribers

Details

Summary

Calling pmc_hook inside a critical section may result in a panic.

This happens when the user callchain is fetched, because it uses pmap_map_user_ptr, that tries to get the (sleepable) pmap lock when the needed vsid is not found.

Judging by the implementation in other platforms, intr_irq_handler in kern/subr_intr.c and what pmc_hook do, it seems safe to move pmc_hook outside the critical section.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable