Page MenuHomeFreeBSD

[PowerPC] Move pmc_hook out of critical section
ClosedPublic

Authored by luporl on Aug 18 2020, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 16, 3:26 PM
Unknown Object (File)
Wed, Apr 15, 3:55 AM
Unknown Object (File)
Wed, Apr 15, 12:58 AM
Unknown Object (File)
Tue, Apr 14, 10:07 PM
Unknown Object (File)
Tue, Apr 14, 9:51 AM
Unknown Object (File)
Fri, Apr 10, 11:55 AM
Unknown Object (File)
Tue, Apr 7, 1:39 PM
Unknown Object (File)
Sun, Apr 5, 10:02 AM
Subscribers

Details

Summary

Calling pmc_hook inside a critical section may result in a panic.

This happens when the user callchain is fetched, because it uses pmap_map_user_ptr, that tries to get the (sleepable) pmap lock when the needed vsid is not found.

Judging by the implementation in other platforms, intr_irq_handler in kern/subr_intr.c and what pmc_hook do, it seems safe to move pmc_hook outside the critical section.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable