Page MenuHomeFreeBSD

[PowerPC] Move pmc_hook out of critical section
ClosedPublic

Authored by luporl on Aug 18 2020, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 4:54 AM
Unknown Object (File)
Fri, Oct 17, 4:54 AM
Unknown Object (File)
Fri, Oct 17, 4:54 AM
Unknown Object (File)
Thu, Oct 16, 7:39 PM
Unknown Object (File)
Sun, Oct 5, 2:53 PM
Unknown Object (File)
Tue, Sep 23, 7:47 AM
Unknown Object (File)
Sep 2 2025, 5:45 PM
Unknown Object (File)
Aug 26 2025, 12:25 PM
Subscribers

Details

Summary

Calling pmc_hook inside a critical section may result in a panic.

This happens when the user callchain is fetched, because it uses pmap_map_user_ptr, that tries to get the (sleepable) pmap lock when the needed vsid is not found.

Judging by the implementation in other platforms, intr_irq_handler in kern/subr_intr.c and what pmc_hook do, it seems safe to move pmc_hook outside the critical section.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable