Page MenuHomeFreeBSD

[PowerPC] Move pmc_hook out of critical section
ClosedPublic

Authored by luporl on Aug 18 2020, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 8:41 PM
Unknown Object (File)
Wed, Aug 12, 4:06 PM
Unknown Object (File)
Wed, Aug 12, 4:06 PM
Unknown Object (File)
Wed, Aug 12, 3:38 AM
Unknown Object (File)
Tue, Aug 11, 6:18 AM
Unknown Object (File)
Mon, Aug 10, 7:48 AM
Unknown Object (File)
Sat, Aug 8, 7:00 PM
Unknown Object (File)
Sat, Aug 8, 9:45 AM
Subscribers

Details

Summary

Calling pmc_hook inside a critical section may result in a panic.

This happens when the user callchain is fetched, because it uses pmap_map_user_ptr, that tries to get the (sleepable) pmap lock when the needed vsid is not found.

Judging by the implementation in other platforms, intr_irq_handler in kern/subr_intr.c and what pmc_hook do, it seems safe to move pmc_hook outside the critical section.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable