Page MenuHomeFreeBSD
Differential D26092

riscv: Use global mimpid in identify_cpu()
ClosedPublic
Actions

Authored by nick on Aug 17 2020, 9:20 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, May 15, 8:39 AM
Unknown Object (File)
Fri, May 15, 6:16 AM
Unknown Object (File)
Fri, May 15, 12:30 AM
Unknown Object (File)
Tue, May 12, 1:19 PM
Unknown Object (File)
Thu, Apr 30, 12:55 PM
Unknown Object (File)
Thu, Apr 23, 1:53 PM
Unknown Object (File)
Wed, Apr 22, 7:05 PM
Unknown Object (File)
Wed, Apr 22, 8:30 AM
View All Files
Subscribers
imp

Details

Reviewers
philip
kp
Group Reviewers
riscv
Commits
rS364349: riscv: Use global mimpid in identify_cpu()
Summary

sbi_init() sets mimpid, we can use that value.

Sponsored by: Axiado

Test Plan

I've tested this on internal hardware and Qemu (with some Qemu hacks as RISCV Qemu returns 0 by default)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nick created this revision.Aug 17 2020, 9:20 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 17 2020, 9:20 PM
nick requested review of this revision.Aug 17 2020, 9:20 PM
philip accepted this revision as: philip.Aug 18 2020, 1:49 AM

Looks good to me.

Would be nice if sbi_init() could also give us misa. ;-)

This revision is now accepted and ready to land.Aug 18 2020, 1:49 AM
kp accepted this revision as: kp.Aug 18 2020, 8:46 AM

Approved by: philip, kp (mentors)

Go ahead and commit this.

Closed by commit rS364349: riscv: Use global mimpid in identify_cpu() (authored by nick). · Explain WhyAug 18 2020, 4:51 PM
This revision was automatically updated to reflect the committed changes.
nick added a commit: rS364349: riscv: Use global mimpid in identify_cpu().

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
riscv/
4 lines

Diff 75950

View Options

head/sys/riscv/riscv/identcpu.c

Loading...