Page MenuHomeFreeBSD

Methodize the TX power limit retrival in ieee80211_ioctl_get80211()
Needs ReviewPublic

Authored by nc on Aug 9 2020, 7:17 PM.
Referenced Files
Unknown Object (File)
Dec 23 2023, 12:21 AM
Unknown Object (File)
Dec 8 2023, 2:12 AM
Unknown Object (File)
Jul 3 2023, 6:07 PM
Unknown Object (File)
Jun 11 2023, 2:18 AM
Unknown Object (File)
Jun 3 2023, 1:08 PM
Unknown Object (File)
May 11 2023, 5:25 AM
Unknown Object (File)
Jan 2 2023, 5:31 AM
Unknown Object (File)
Jan 1 2023, 9:56 AM

Details

Reviewers
adrian
bz
Summary

Methodize the TX power limit retrival in ieee80211_ioctl_get80211().

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nc requested review of this revision.Aug 9 2020, 7:17 PM

Keep in mind that should this patch get approved, someone other than me will need to commit this.

I am not a committer, I just share a name with one.

hi!

Let's make it more generic - and I thought it was - oh yeah! Look at ieee80211_get_node_txpower().

Maybe do this:

  • create a ieee80211_get_channel_txpower(), in ieee80211_var.h

.. next to the existing node one

  • make the ioctl api use that

How's that sound?

Sounds good, will post a patch shortly.

Here's the updated diff.

I have the stupid question (without looking):

where else do we need this calculation?
I cannot imagine it is just in the ioctl?
What do we need for 11h?
Do we have a function which does return the actual value without the ireq or should we have that?

It could be the answer to all of this is "no"(-a-like) and then sorry for the noise from a reply at 1am.