Methodize the TX power limit retrival in ieee80211_ioctl_get80211()

[nc]

Summary

Methodize the TX power limit retrival in ieee80211_ioctl_get80211().

Submitted by: Neel Chauhan <neel AT neelc DOT org>

[nc]

Keep in mind that should this patch get approved, someone other than me will need to commit this.

I am not a committer, I just share a name with one.

[adrian]

hi!

Let's make it more generic - and I thought it was - oh yeah! Look at ieee80211_get_node_txpower().

Maybe do this:

• create a ieee80211_get_channel_txpower(), in ieee80211_var.h

[adrian]

.. next to the existing node one

• make the ioctl api use that

How's that sound?

[nc]

Sounds good, will post a patch shortly.

[nc]

Here's the updated diff.

[bz]

I have the stupid question (without looking):

where else do we need this calculation?
I cannot imagine it is just in the ioctl?
What do we need for 11h?
Do we have a function which does return the actual value without the ireq or should we have that?

It could be the answer to all of this is "no"(-a-like) and then sorry for the noise from a reply at 1am.

[adrian]

oh damn i missed this, I think it's worth refactoring it so we do have a specific place to pull the TX power from.

Also in today's tree there's ieee80211_get_node_txpower() which does this work too, so we could quickly refactor that as part of this commit.

I'll tackle it soon.

[bz]

Making this an inline function for the point of making it a function seems hard to justify for single use code.
Can we at least keep it as a normal function in ioctl.c?