Page MenuHomeFreeBSD

Remove headers from iommu.h
ClosedPublic

Authored by br on Wed, Jul 29, 1:43 PM.

Details

Summary

Remove headers from iommu.h

Test Plan

boot amd64

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

br requested review of this revision.Wed, Jul 29, 1:43 PM
br created this revision.
kib added inline comments.Wed, Jul 29, 2:52 PM
sys/dev/iommu/iommu_gas.c
72 ↗(On Diff #75123)

This is quite weird #ifdef block. Why pci and iommu are under ifdef ?

sys/x86/iommu/intel_drv.c
72 ↗(On Diff #75123)

I propose to make the order of headers consistent. Put dev/pci right after vm/, then dev/iommu, then x86 headers.

br added inline comments.Wed, Jul 29, 3:51 PM
sys/x86/iommu/intel_drv.c
72 ↗(On Diff #75123)

dev/iommu/busdma_iommu.h depends on struct bus_dma_tag_common, which is defined in x86/include/busdma_impl.h.
so x86 header should go first ?

cy added a subscriber: cy.Wed, Jul 29, 5:04 PM
kib added inline comments.Wed, Jul 29, 7:06 PM
sys/x86/iommu/intel_drv.c
72 ↗(On Diff #75123)

Might be. What provides a similar common structure on arm64 ?

br updated this revision to Diff 75144.Wed, Jul 29, 9:13 PM

Fix order of headers:
sys/vm/contrib/dev/machine/x86

br added inline comments.Wed, Jul 29, 9:15 PM
sys/x86/iommu/intel_drv.c
72 ↗(On Diff #75123)

arm64/include/bus_dma_impl.h

kib accepted this revision.Wed, Jul 29, 9:48 PM
This revision is now accepted and ready to land.Wed, Jul 29, 9:48 PM
This revision was automatically updated to reflect the committed changes.