Page MenuHomeFreeBSD
Differential D25802

Move GAS prototypes and flags
ClosedPublic
Actions

Authored by br on Jul 25 2020, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 8, 3:24 AM
Unknown Object (File)
Wed, Nov 5, 6:51 AM
Unknown Object (File)
Wed, Nov 5, 6:49 AM
Unknown Object (File)
Wed, Nov 5, 6:48 AM
Unknown Object (File)
Wed, Nov 5, 6:48 AM
Unknown Object (File)
Wed, Nov 5, 6:40 AM
Unknown Object (File)
Thu, Oct 23, 3:24 PM
Unknown Object (File)
Tue, Oct 21, 6:28 AM
View All 96 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS363533: o Move iommu gas prototypes, DMAR flags to iommu.h;
Summary

Move GAS prototypes, and domain flags to iommu.h

I will rename DMAR_ to IOMMU_ for these flags on next diff

Test Plan

Boot on amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br requested review of this revision.Jul 25 2020, 3:39 PM
br created this revision.
br edited the summary of this revision. (Show Details)
br retitled this revision from move GAS headers and flags to Move GAS prototypes and flags.Jul 25 2020, 3:49 PM
br edited the summary of this revision. (Show Details)
br edited the test plan for this revision. (Show Details)
kib added inline comments.Jul 25 2020, 4:04 PM
sys/dev/iommu/iommu_gas.c
734 ↗(On Diff #74920)

Does this var need to be extern after the move ?

br updated this revision to Diff 74925.Jul 25 2020, 6:20 PM

Remove TUNABLE_INT_FETCH and make check_free static

sys/dev/iommu/iommu_gas.c
734 ↗(On Diff #74920)

I think TUNABLE_INT_FETCH is not needed since we use SYSCTL_INT ?
So I removed it and made check_free static

kib accepted this revision.Jul 25 2020, 6:36 PM
kib added inline comments.
sys/dev/iommu/iommu_gas.c
736 ↗(On Diff #74925)

Ok but make node non-static, and add hw.iommu node declaration into the header. Then convert all hw.dmar into hw.iommu.dmar. All this in the next commit.

This revision is now accepted and ready to land.Jul 25 2020, 6:36 PM
Closed by commit rS363533: o Move iommu gas prototypes, DMAR flags to iommu.h; (authored by br). · Explain WhyJul 25 2020, 7:07 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS363533: o Move iommu gas prototypes, DMAR flags to iommu.h;.
Herald added a subscriber: imp. · View Herald TranscriptJul 25 2020, 7:07 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iommu/
36 lines
12 lines
x86/
iommu/
37 lines
3 lines
7 lines

Diff 74927

View Options

head/sys/dev/iommu/iommu.h

Loading...
View Options

head/sys/dev/iommu/iommu_gas.c

Loading...
View Options

head/sys/x86/iommu/intel_dmar.h

Loading...
View Options

head/sys/x86/iommu/intel_drv.c

Loading...
View Options

head/sys/x86/iommu/intel_utils.c

Loading...