Page MenuHomeFreeBSD

Move GAS prototypes and flags
ClosedPublic

Authored by br on Jul 25 2020, 3:39 PM.

Details

Summary

Move GAS prototypes, and domain flags to iommu.h

I will rename DMAR_ to IOMMU_ for these flags on next diff

Test Plan

Boot on amd64

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

br requested review of this revision.Jul 25 2020, 3:39 PM
br created this revision.
br edited the summary of this revision. (Show Details)
br retitled this revision from move GAS headers and flags to Move GAS prototypes and flags.Jul 25 2020, 3:49 PM
br edited the summary of this revision. (Show Details)
br edited the test plan for this revision. (Show Details)
sys/dev/iommu/iommu_gas.c
734 ↗(On Diff #74920)

Does this var need to be extern after the move ?

Remove TUNABLE_INT_FETCH and make check_free static

sys/dev/iommu/iommu_gas.c
734 ↗(On Diff #74920)

I think TUNABLE_INT_FETCH is not needed since we use SYSCTL_INT ?
So I removed it and made check_free static

kib added inline comments.
sys/dev/iommu/iommu_gas.c
736 ↗(On Diff #74925)

Ok but make node non-static, and add hw.iommu node declaration into the header. Then convert all hw.dmar into hw.iommu.dmar. All this in the next commit.

This revision is now accepted and ready to land.Jul 25 2020, 6:36 PM
This revision was automatically updated to reflect the committed changes.