libpmc: Use known pmc_cpuid buffer size
ClosedPublic
Actions

Authored by freqlabs on Jul 15 2020, 5:21 PM.

Details

Reviewers

Commits

rS363831: MFC r363630:
rS363630: libpmc: Use known pmc_cpuid buffer size

Summary

Use the existing PMC_CPUID_LEN to size pmc_cpuid in the kernel and various buffers for reading it in libpmc.
This avoids some extra syscalls and malloc/frees.

While in here, use strlcpy to copy a user-provided cpuid string instead of memcpy, to make sure we terminate the buffer.

Sorry for the extra review noise mav, this ended up changing a bit after taking a final look at the original patch :)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freqlabs created this revision.Jul 15 2020, 5:21 PM

Herald added subscribers: gnn, imp. · View Herald TranscriptJul 15 2020, 5:21 PM

freqlabs requested review of this revision.Jul 15 2020, 5:21 PM

Going to commit this tonight since there has been no objection

With kernel part I am definitely agree, while about first part of user space just won't object. While second part of user-space just had no sense before, the first one at least had some sense, even though not willing much.

This revision is now accepted and ready to land.Jul 28 2020, 1:21 AM

Closed by commit rS363630: libpmc: Use known pmc_cpuid buffer size (authored by freqlabs). · Explain WhyJul 28 2020, 2:56 AM

This revision was automatically updated to reflect the committed changes.

freqlabs added a commit: rS363630: libpmc: Use known pmc_cpuid buffer size.

freqlabs added a commit: rS363831: MFC r363630:.Aug 4 2020, 12:05 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libpmc/

libpmc_pmu_util.c

24 lines

sys/

dev/

hwpmc/

hwpmc_mod.c

2 lines

Diff 75036

View Options

head/lib/libpmc/libpmc_pmu_util.c

This file was added.

				Disable debugging assertions in pthreads library.
				kibUnsubmitted Not Done Inline Actions The svn tags are not needed for new files. kib: The svn tags are not needed for new files.