Page MenuHomeFreeBSD

Handbook: Jails, add upgrade instructions
ClosedPublic

Authored by gbe on Jul 14 2020, 5:14 PM.
Tags
None
Referenced Files
F82893372: D25668.diff
Fri, May 3, 4:34 PM
Unknown Object (File)
Dec 23 2023, 12:24 AM
Unknown Object (File)
Aug 2 2023, 8:32 AM
Unknown Object (File)
Jul 21 2023, 2:27 PM
Unknown Object (File)
Jun 21 2023, 8:03 AM
Unknown Object (File)
Jun 6 2023, 11:12 PM
Unknown Object (File)
Jun 3 2023, 8:18 AM
Unknown Object (File)
May 14 2023, 6:55 PM
Subscribers

Details

Summary

Handbook: Jails, add upgrade instructions.

PR 247927

Test Plan

compile the handbook and review the html output.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32328
Build 29811: arc lint + arc unit

Event Timeline

gbe requested review of this revision.Jul 14 2020, 5:14 PM
gbe created this revision.

Here's a few nits I noticed.

en_US.ISO8859-1/books/handbook/jails/chapter.xml
538–541

I think this needs a bit of wordsmithing - it's unclear whether it's talking about the host or the jail.
If it's about the jail, I believe the example below also needs --currently-running.

543

I think you've got an extra space that snuck in just before /here.

545–546

I think it would be better to refer to it as "the latest patch level" instead of "a new version", and drop the parenthesis about security updates as patch-levels include both security updates but also errata notices.

  • Update the wording in the first new paragraph and remove some whitespaces
gbe marked 2 inline comments as done.Jul 14 2020, 7:23 PM

Address some comments from @debdrup

en_US.ISO8859-1/books/handbook/jails/chapter.xml
545–546

The command examples referring to a new point release of the stable branch, so I would think that speaking of "the latest patch level" would be wrong. What do you think about new paragraph above that one that aims for patch level updates?

en_US.ISO8859-1/books/handbook/jails/chapter.xml
545–546

Well, as an example, 12.2 will start out life as a repocopy of stable/12 to releng/12.2, so I don't think the description of 'a new point release of the stable branch' is the most accurate description, but I clearly misunderstood what the sentence was saying, since I now think understand what you were trying to say. I also think avoiding the phrase 'point release' is a good idea, as it is a bit less well-defined, as I've seen people use it to refer to the X in both 12.X and 12.1pX?

What do you think about "To upgrade the jail to a new major or minor version, first upgrade the host system as described…"?
That makes it clear that it works for both FreeBSD-X and FreeBSD-X.Y.

  • Make it more clear that major and minor versions can be upgraded
gbe marked an inline comment as done.Jul 14 2020, 7:57 PM
gbe added inline comments.
en_US.ISO8859-1/books/handbook/jails/chapter.xml
545–546

I updated the paragraph. I am not the author of the original patch and I haven't used jails that much recently, so your feedback is more than appreciated. :)

bcr added a subscriber: bcr.

Thanks for working on this PR, I think with the changes from @debdrup it is much better now and good to go into the handbook.

This revision is now accepted and ready to land.Jul 16 2020, 2:06 PM
This revision was automatically updated to reflect the committed changes.
gbe marked an inline comment as done.