Page MenuHomeFreeBSD

loader: GELI writes are not yet implemented
ClosedPublic

Authored by tsoome on Jul 9 2020, 9:12 PM.

Details

Summary

implement geli writes, needed to support zfsbootcfg boot command.

Bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247482

This work is based on https://reviews.freebsd.org/D10236 by Allan Jude.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tsoome requested review of this revision.Jul 9 2020, 9:12 PM
tsoome created this revision.
rpokala added inline comments.
stand/libsa/geli/gelidev.c
174 ↗(On Diff #74258)

"Need to read/modify/write, so read and decrypt, then modify."

Hopefully better comment.

LGTM, but you probably want to hear from someone who knows more (read: anything) about GELI. :-)

(It was convenient that geliboot_crypt() already supported encryption, even though it wasn't actually used until this change.)

This revision was not accepted when it landed; it landed in state Needs Review.Jul 11 2020, 6:52 AM
This revision was automatically updated to reflect the committed changes.