Page MenuHomeFreeBSD
Differential D25605

loader: GELI writes are not yet implemented
ClosedPublic
Actions

Authored by tsoome on Jul 9 2020, 9:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 8:14 PM
Unknown Object (File)
Sun, Jan 19, 6:30 PM
Unknown Object (File)
Mon, Jan 13, 6:29 PM
Unknown Object (File)
Jan 7 2025, 2:50 PM
Unknown Object (File)
Dec 12 2024, 9:55 AM
Unknown Object (File)
Dec 6 2024, 2:03 PM
Unknown Object (File)
Dec 4 2024, 9:11 AM
Unknown Object (File)
Oct 28 2024, 12:55 AM
View All 78 Files
Subscribers
rpokala

Details

Reviewers
allanjude
imp
Commits
rS363090: loader: implement GELI writes
Summary

implement geli writes, needed to support zfsbootcfg boot command.

Bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247482

This work is based on https://reviews.freebsd.org/D10236 by Allan Jude.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome requested review of this revision.Jul 9 2020, 9:12 PM
tsoome created this revision.
Harbormaster completed remote builds in B32218: Diff 74258.Jul 9 2020, 9:12 PM
rpokala added a subscriber: rpokala.Jul 9 2020, 10:05 PM
rpokala added inline comments.
stand/libsa/geli/gelidev.c
174 ↗(On Diff #74258)

"Need to read/modify/write, so read and decrypt, then modify."

tsoome edited the summary of this revision. (Show Details)Jul 9 2020, 10:32 PM
tsoome updated this revision to Diff 74261.Jul 9 2020, 10:34 PM

Hopefully better comment.

Harbormaster completed remote builds in B32221: Diff 74261.Jul 9 2020, 10:34 PM
rpokala added a comment.Jul 9 2020, 10:53 PM

LGTM, but you probably want to hear from someone who knows more (read: anything) about GELI. :-)

(It was convenient that geliboot_crypt() already supported encryption, even though it wasn't actually used until this change.)

tsoome marked an inline comment as done.Jul 9 2020, 10:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 11 2020, 6:52 AM
Closed by commit rS363090: loader: implement GELI writes (authored by tsoome). · Explain Why
This revision was automatically updated to reflect the committed changes.
tsoome added a commit: rS363090: loader: implement GELI writes.

Revision Contents
Changeset List

PathSize
head/
stand/
i386/
gptboot/
2 lines
libsa/
geli/
10 lines
8 lines
32 lines
4 lines
75 lines

Diff 74290

View Options

head/stand/i386/gptboot/gptboot.c

Loading...
View Options

head/stand/libsa/geli/geliboot.h

Loading...
View Options

head/stand/libsa/geli/geliboot.c

Loading...
View Options

head/stand/libsa/geli/geliboot_crypto.c

Loading...
View Options

head/stand/libsa/geli/geliboot_internal.h

Loading...
View Options

head/stand/libsa/geli/gelidev.c

Loading...