New port: shells/ohmyzsh

[skozlov]

Summary

Oh My Zsh is an open source, community-driven framework for managing your zsh configuration.
Port version has install, uninstall, and upgrade functionalities removed.
Internal paths are adjusted to allow multiple users to use Oh My Zsh together.

Test Plan

portlint OK
poudriere OK
smoke test OK

[skozlov]

Change WWW: in pkg-descr to a prettier site.

[mat]

The port is missing a runtime dependency on zsh.

shells/ohmyzsh/Makefile

23 ↗

(On Diff #74142)

Patching has to happen in the patch phase.

24–27 ↗

(On Diff #74142)

This probably need to be moved to post-extract, as it is cleanup of the distribution file, and has nothing to do with the configure step.

[skozlov]

• Fix issues reported by @mat
• Re-pharse pkg-message

[skozlov]

In D25582#565819, @mat wrote:

The port is missing a runtime dependency on zsh.

Fixed. Thank you for the feedback.

[fernape]

shells/ohmyzsh/Makefile

18 ↗

(On Diff #74153)

These are standard bsd.port.mk variables.

They better be after USE_* block

[skozlov]

Fix the issue reported by @fernape

[skozlov]

Fix props

[fernape]

Builds in {11.4,12.1}{amd64,i386} and 13-current amd64.

Seems to work fine in 12.1 amd64 (I did light testing since I'm not a zsh user).

LGTM!

[skozlov]

In D25582#566025, @fernape wrote:

Builds in {11.4,12.1}{amd64,i386} and 13-current amd64.

Seems to work fine in 12.1 amd64 (I did light testing since I'm not a zsh user).

LGTM!

Thanks a lot!

[mat]

Could you also add descriptions to the patch files? Like "This removes the auto-update bits" or something?

head/shells/ohmyzsh/files/patch-oh-my-zsh.sh

13

This path feels wrong, it should probably be using ${XDG_CACHE_HOME:-$HOME/.cache}/oh-my-zsh instead of doing its own thing in some strange location. (But it may just be me trying to make things respect XDG base directories.)

head/shells/ohmyzsh/pkg-descr

1–15

The pkg-descr is supposed to remain factual, this, while fun, is a bit too on the zealot side. Could you maybe rewrite it to explain what it does instead of how great it is?

[fernape]

In D25582#566044, @mat wrote:

Could you also add descriptions to the patch files? Like "This removes the auto-update bits" or something?

I filed PR 247887 with all those suggestions.

Thanks!