Page MenuHomeFreeBSD
Differential D25560

Fix a lock order reversal during jail/vnet creation
Needs ReviewPublic
Actions

Authored by syrinx on Jul 4 2020, 8:31 AM.
Tags
None
Referenced Files
F103401184: D25560.id.diff
Sun, Nov 24, 1:15 PM
Unknown Object (File)
Sep 29 2024, 6:14 AM
Unknown Object (File)
Sep 22 2024, 5:34 PM
Unknown Object (File)
Sep 17 2024, 6:39 PM
Unknown Object (File)
Sep 5 2024, 11:38 AM
Unknown Object (File)
Aug 18 2024, 5:10 AM
Unknown Object (File)
Aug 14 2024, 7:18 AM
Unknown Object (File)
Aug 4 2024, 9:13 PM
View All 26 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
bz
kp
jamie
Summary

Fix the following LOR reported by the FreeBSD kyua test suite -

1st 0xffffffff81c900e0 allprison (allprison) @ /usr/src/sys/kern/kern_jail.c:984
2nd 0xffffffff81d9b690 vnet_sysinit_sxlock (vnet_sysinit_sxlock) @ /usr/src/sys/net/vnet.c:577

Test Plan

On a kernel with WITNESS options enabled, run an inet test, e.g.

kyua test -k /usr/tests/sys/netinet/Kyuafile forward:fwd_ip_icmp_gw_fast_success

Verify no lock order reversals are reported.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32132
Build 29643: arc lint + arc unit

Event Timeline

syrinx created this revision.Jul 4 2020, 8:31 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJul 4 2020, 8:31 AM
syrinx requested review of this revision.Jul 4 2020, 8:31 AM
Harbormaster completed remote builds in B32132: Diff 74064.Jul 4 2020, 8:31 AM
syrinx edited the test plan for this revision. (Show Details)Jul 4 2020, 8:37 AM
syrinx added reviewers: bz, kp, jamie.
syrinx edited the test plan for this revision. (Show Details)
jamie added a comment.Aug 30 2020, 12:09 AM

The patch looks good to me, but I'm unable to get that LOR on an unpatched system. Has something been fixed in the meantime?

Revision Contents
Changeset List

PathSize
sys/
kern/
27 lines

Diff 74064

View Options

sys/kern/kern_jail.c

Loading...